From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20370 invoked by alias); 13 Jun 2003 19:40:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20354 invoked from network); 13 Jun 2003 19:40:44 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.131) by sources.redhat.com with SMTP; 13 Jun 2003 19:40:44 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 583142B5F; Fri, 13 Jun 2003 15:40:37 -0400 (EDT) Message-ID: <3EEA28B5.2070807@redhat.com> Date: Fri, 13 Jun 2003 19:40:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Richard.Earnshaw@arm.com Cc: gdb-patches@sources.redhat.com Subject: Re: [patch rfc] -Wmissing-prototypes round #3 References: <200306131413.h5DEDuQ01304@pc960.cambridge.arm.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00477.txt.bz2 > ac131313@redhat.com said: >> > > >> >> * config/arm/tm-linux.h (arm_linux_svr4_fetch_link_map_offsets): >> >> Delete declaration, moved to "arm-tdep.h". Include "arm-tdep.h". >> >> * arm-tdep.h: Add ARM_TDEP_H wrapper. >> >> (arm_linux_svr4_fetch_link_map_offsets): Declare. > >> > >> > >> > arm_linux_svr4_fetch_link_map_offsets should be moved from arm-tdep.c to >> > armlinux-tdep.c. Then it can be made private to that file; it doesn't >> > belong in the generic ARM code. > >> >> Please be my guest, it will simplify my -Wmissing-prototypes patch. >> > > > Done. Thanks, just re-generating a -Wmissing-prototypes build to see what's left. Andrew