* [commit] Split d10v-tdep.c into trad-frame.[hc]
@ 2003-06-08 16:15 Andrew Cagney
2003-06-08 16:58 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2003-06-08 16:15 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
Hello,
This moves a chunk of d10v's frame unwind code into trad-frame.[hc]. It
creates a simple framework that traditional unwinders can use - a
successor to get_frame_saved_regs().
Handling the problem of the previous frame's PC being in this frame's LR
is remarkably simple - just copy the saved location of LR into PC!
committed,
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 16814 bytes --]
2003-06-08 Andrew Cagney <cagney@redhat.com>
* Makefile.in (d10v-tdep.o): Update dependencies.
(SFILES): Add trad-frame.c.
(trad_frame_h): Define.
(COMMON_OBS): Add trad-frame.o.
(trad-frame.o): Specify dependencies.
* d10v-tdep.c: Include "trad-frame.h".
(saved_regs_unwinder): Delete function.
(d10v_frame_prev_register): Use trad_frame_prev_register.
(struct d10v_unwind_cache): Change type of "saved_regs" to "struct
trad_frame", delete "regs" and "prev_sp".
(prologue_find_regs): Use trad-frame.
* trad-frame.h, trad-frame.c: New files.
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.392
diff -u -r1.392 Makefile.in
--- Makefile.in 7 Jun 2003 18:08:23 -0000 1.392
+++ Makefile.in 8 Jun 2003 16:04:01 -0000
@@ -540,7 +540,9 @@
sentinel-frame.c \
serial.c ser-unix.c source.c \
stabsread.c stack.c std-regs.c symfile.c symmisc.c symtab.c \
- target.c thread.c top.c tracepoint.c typeprint.c \
+ target.c thread.c top.c tracepoint.c \
+ trad-frame.c \
+ typeprint.c \
tui/tui.c tui/tui.h tui/tuiCommand.c tui/tuiCommand.h \
tui/tuiData.c tui/tuiData.h tui/tuiDataWin.c tui/tuiDataWin.h \
tui/tuiDisassem.c tui/tuiDisassem.h tui/tuiGeneralWin.c \
@@ -729,6 +731,7 @@
target_h = target.h $(bfd_h) $(symtab_h) $(dcache_h) $(memattr_h)
terminal_h = terminal.h
top_h = top.h
+trad_frame_h = trad-frame.h
infttrace_h = infttrace.h
tracepoint_h = tracepoint.h
typeprint_h = typeprint.h
@@ -871,7 +874,8 @@
frame-base.o \
gnu-v2-abi.o gnu-v3-abi.o hpacc-abi.o cp-abi.o cp-support.o \
cp-namespace.o \
- reggroups.o
+ reggroups.o \
+ trad-frame.o
OBS = $(COMMON_OBS) $(ANNOTATE_OBS)
@@ -1643,9 +1647,9 @@
d10v-tdep.o: d10v-tdep.c $(defs_h) $(frame_h) $(frame_unwind_h) \
$(frame_base_h) $(symtab_h) $(gdbtypes_h) $(gdbcmd_h) $(gdbcore_h) \
$(gdb_string_h) $(value_h) $(inferior_h) $(dis_asm_h) $(symfile_h) \
- $(objfiles_h) $(language_h) $(arch_utils_h) $(regcache_h) \
- $(remote_h) $(floatformat_h) $(gdb_sim_d10v_h) $(sim_regno_h) \
- $(gdb_assert_h) $(disasm_h)
+ $(objfiles_h) $(language_h) $(arch_utils_h) $(regcache_h) $(remote_h) \
+ $(floatformat_h) $(gdb_sim_d10v_h) $(sim_regno_h) $(disasm_h) \
+ $(trad_frame_h) $(gdb_assert_h)
dbug-rom.o: dbug-rom.c $(defs_h) $(gdbcore_h) $(target_h) $(monitor_h) \
$(serial_h) $(regcache_h) $(m68k_tdep_h)
dbxread.o: dbxread.c $(defs_h) $(gdb_string_h) $(gdb_obstack_h) \
@@ -2309,6 +2313,7 @@
$(gdb_string_h) $(inferior_h) $(tracepoint_h) $(remote_h) \
$(linespec_h) $(regcache_h) $(completer_h) $(gdb_events_h) \
$(block_h) $(ax_h) $(ax_gdb_h) $(readline_h)
+trad-frame.o: trad-frame.c $(defs_h) $(frame_h) $(trad_frame_h) $(regcache_h)
typeprint.o: typeprint.c $(defs_h) $(gdb_obstack_h) $(bfd_h) $(symtab_h) \
$(gdbtypes_h) $(expression_h) $(value_h) $(gdbcore_h) $(command_h) \
$(gdbcmd_h) $(target_h) $(language_h) $(cp_abi_h) $(gdb_string_h)
Index: d10v-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/d10v-tdep.c,v
retrieving revision 1.119
diff -u -r1.119 d10v-tdep.c
--- d10v-tdep.c 6 Jun 2003 21:27:35 -0000 1.119
+++ d10v-tdep.c 8 Jun 2003 16:04:01 -0000
@@ -44,6 +44,7 @@
#include "gdb/sim-d10v.h"
#include "sim-regno.h"
#include "disasm.h"
+#include "trad-frame.h"
#include "gdb_assert.h"
@@ -569,14 +570,14 @@
/* The frame's base, optionally used by the high-level debug info. */
CORE_ADDR base;
int size;
- CORE_ADDR *saved_regs;
/* How far the SP and r11 (FP) have been offset from the start of
the stack frame (as defined by the previous frame's stack
pointer). */
LONGEST sp_offset;
LONGEST r11_offset;
int uses_frame;
- void **regs;
+ /* Table indicating the location of each and every register. */
+ struct trad_frame *saved_regs;
};
static int
@@ -590,7 +591,7 @@
{
n = (op & 0x1E0) >> 5;
info->sp_offset -= 2;
- info->saved_regs[n] = info->sp_offset;
+ info->saved_regs[n].addr = info->sp_offset;
return 1;
}
@@ -599,8 +600,8 @@
{
n = (op & 0x1E0) >> 5;
info->sp_offset -= 4;
- info->saved_regs[n] = info->sp_offset;
- info->saved_regs[n + 1] = info->sp_offset + 2;
+ info->saved_regs[n + 0].addr = info->sp_offset + 0;
+ info->saved_regs[n + 1].addr = info->sp_offset + 2;
return 1;
}
@@ -626,7 +627,7 @@
if ((op & 0x7E1F) == 0x6816)
{
n = (op & 0x1E0) >> 5;
- info->saved_regs[n] = info->r11_offset;
+ info->saved_regs[n].addr = info->r11_offset;
return 1;
}
@@ -638,7 +639,7 @@
if ((op & 0x7E1F) == 0x681E)
{
n = (op & 0x1E0) >> 5;
- info->saved_regs[n] = info->sp_offset;
+ info->saved_regs[n].addr = info->sp_offset;
return 1;
}
@@ -646,8 +647,8 @@
if ((op & 0x7E3F) == 0x3A1E)
{
n = (op & 0x1E0) >> 5;
- info->saved_regs[n] = info->sp_offset;
- info->saved_regs[n + 1] = info->sp_offset + 2;
+ info->saved_regs[n + 0].addr = info->sp_offset + 0;
+ info->saved_regs[n + 1].addr = info->sp_offset + 2;
return 1;
}
@@ -678,7 +679,7 @@
info = FRAME_OBSTACK_ZALLOC (struct d10v_unwind_cache);
(*this_prologue_cache) = info;
- info->saved_regs = FRAME_OBSTACK_CALLOC (NUM_REGS, CORE_ADDR);
+ info->saved_regs = trad_frame_alloc_saved_regs (next_frame);
info->size = 0;
info->sp_offset = 0;
@@ -703,15 +704,15 @@
/* st rn, @(offset,sp) */
short offset = op & 0xFFFF;
short n = (op >> 20) & 0xF;
- info->saved_regs[n] = info->sp_offset + offset;
+ info->saved_regs[n].addr = info->sp_offset + offset;
}
else if ((op & 0x3F1F0000) == 0x350F0000)
{
/* st2w rn, @(offset,sp) */
short offset = op & 0xFFFF;
short n = (op >> 20) & 0xF;
- info->saved_regs[n] = info->sp_offset + offset;
- info->saved_regs[n + 1] = info->sp_offset + offset + 2;
+ info->saved_regs[n + 0].addr = info->sp_offset + offset + 0;
+ info->saved_regs[n + 1].addr = info->sp_offset + offset + 2;
}
else
break;
@@ -737,7 +738,8 @@
info->size = -info->sp_offset;
- /* Compute the frame's base, and the previous frame's SP. */
+ /* Compute the previous frame's stack pointer (which is also the
+ frame's ID's stack address), and this frame's base pointer. */
if (info->uses_frame)
{
/* The SP was moved to the FP. This indicates that a new frame
@@ -748,16 +750,6 @@
to before the first saved register giving the SP. */
prev_sp = this_base + info->size;
}
- else if (info->saved_regs[D10V_SP_REGNUM])
- {
- /* The SP was saved (which is very unusual), the frame base is
- just the PREV's frame's TOP-OF-STACK. */
- this_base
- = get_frame_memory_unsigned (next_frame,
- info->saved_regs[D10V_SP_REGNUM],
- register_size (gdbarch, D10V_SP_REGNUM));
- prev_sp = this_base;
- }
else
{
/* Assume that the FP is this frame's SP but with that pushed
@@ -766,20 +758,28 @@
prev_sp = this_base + info->size;
}
+ /* Convert that SP/BASE into real addresses. */
+ info->prev_sp = d10v_make_daddr (prev_sp);
info->base = d10v_make_daddr (this_base);
- info->prev_sp = d10v_make_daddr (prev_sp);
/* Adjust all the saved registers so that they contain addresses and
not offsets. */
for (i = 0; i < NUM_REGS - 1; i++)
- if (info->saved_regs[i])
+ if (info->saved_regs[i].addr)
{
- info->saved_regs[i] = (info->prev_sp + info->saved_regs[i]);
+ info->saved_regs[i].addr = (info->prev_sp + info->saved_regs[i].addr);
}
- /* The D10V_SP_REGNUM is special. Instead of the address of the SP, the
- previous frame's SP value is saved. */
- info->saved_regs[D10V_SP_REGNUM] = info->prev_sp;
+ /* The call instruction moves the caller's PC in the callee's LR.
+ Since this is an unwind, do the reverse. Copy the location of LR
+ into PC (the address / regnum) so that a request for PC will be
+ converted into a request for the LR. */
+ info->saved_regs[D10V_PC_REGNUM] = info->saved_regs[LR_REGNUM];
+
+ /* The previous frame's SP needed to be computed. Save the computed
+ value. */
+ trad_frame_register_value (info->saved_regs, D10V_SP_REGNUM,
+ d10v_make_daddr (prev_sp));
return info;
}
@@ -1430,55 +1430,6 @@
}
static void
-saved_regs_unwinder (struct frame_info *next_frame,
- CORE_ADDR *this_saved_regs,
- int regnum, int *optimizedp,
- enum lval_type *lvalp, CORE_ADDR *addrp,
- int *realnump, void *bufferp)
-{
- struct gdbarch *gdbarch = get_frame_arch (next_frame);
- if (this_saved_regs[regnum] != 0)
- {
- if (regnum == D10V_SP_REGNUM)
- {
- /* SP register treated specially. */
- *optimizedp = 0;
- *lvalp = not_lval;
- *addrp = 0;
- *realnump = -1;
- if (bufferp != NULL)
- store_unsigned_integer (bufferp,
- register_size (gdbarch, regnum),
- this_saved_regs[regnum]);
- }
- else
- {
- /* Any other register is saved in memory, fetch it but cache
- a local copy of its value. */
- *optimizedp = 0;
- *lvalp = lval_memory;
- *addrp = this_saved_regs[regnum];
- *realnump = -1;
- if (bufferp != NULL)
- {
- /* Read the value in from memory. */
- get_frame_memory (next_frame, this_saved_regs[regnum], bufferp,
- register_size (gdbarch, regnum));
- }
- }
- return;
- }
-
- /* No luck, assume this and the next frame have the same register
- value. If a value is needed, pass the request on down the chain;
- otherwise just return an indication that the value is in the same
- register as the next frame. */
- frame_register_unwind (next_frame, regnum, optimizedp, lvalp, addrp,
- realnump, bufferp);
-}
-
-
-static void
d10v_frame_prev_register (struct frame_info *next_frame,
void **this_prologue_cache,
int regnum, int *optimizedp,
@@ -1487,19 +1438,8 @@
{
struct d10v_unwind_cache *info
= d10v_frame_unwind_cache (next_frame, this_prologue_cache);
- if (regnum == D10V_PC_REGNUM)
- {
- /* The call instruction saves the caller's PC in LR. The
- function prologue of the callee may then save the LR on the
- stack. Find that possibly saved LR value and return it. */
- saved_regs_unwinder (next_frame, info->saved_regs, LR_REGNUM, optimizedp,
- lvalp, addrp, realnump, bufferp);
- }
- else
- {
- saved_regs_unwinder (next_frame, info->saved_regs, regnum, optimizedp,
- lvalp, addrp, realnump, bufferp);
- }
+ trad_frame_prev_register (next_frame, info->saved_regs, regnum,
+ optimizedp, lvalp, addrp, realnump, bufferp);
}
static const struct frame_unwind d10v_frame_unwind = {
Index: trad-frame.c
===================================================================
RCS file: trad-frame.c
diff -N trad-frame.c
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ trad-frame.c 8 Jun 2003 16:04:02 -0000
@@ -0,0 +1,96 @@
+/* Traditional frame unwind support, for GDB the GNU Debugger.
+
+ Copyright 2003 Free Software Foundation, Inc.
+
+ This file is part of GDB.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 59 Temple Place - Suite 330,
+ Boston, MA 02111-1307, USA. */
+
+#include "defs.h"
+#include "frame.h"
+#include "trad-frame.h"
+#include "regcache.h"
+
+/* A traditional frame is unwound by analysing the function prologue
+ and using the information gathered to track registers. For
+ non-optimized frames, the technique is reliable (just need to check
+ for all potential instruction sequences). */
+
+struct trad_frame *
+trad_frame_alloc_saved_regs (struct frame_info *next_frame)
+{
+ int i;
+ struct gdbarch *gdbarch = get_frame_arch (next_frame);
+ int numregs = NUM_REGS + NUM_PSEUDO_REGS;
+ struct trad_frame *this_saved_regs
+ = FRAME_OBSTACK_CALLOC (numregs, struct trad_frame);
+ for (i = 0; i < numregs; i++)
+ this_saved_regs[i].regnum = i;
+ return this_saved_regs;
+}
+
+void
+trad_frame_register_value (struct trad_frame this_saved_regs[],
+ int regnum, LONGEST val)
+{
+ /* Make the REGNUM invalid, indicating that the ADDR contains the
+ register's value. */
+ this_saved_regs[regnum].regnum = -1;
+ this_saved_regs[regnum].addr = val;
+}
+
+void
+trad_frame_prev_register (struct frame_info *next_frame,
+ struct trad_frame this_saved_regs[],
+ int regnum, int *optimizedp,
+ enum lval_type *lvalp, CORE_ADDR *addrp,
+ int *realnump, void *bufferp)
+{
+ struct gdbarch *gdbarch = get_frame_arch (next_frame);
+ if (this_saved_regs[regnum].regnum >= 0
+ && this_saved_regs[regnum].addr != 0)
+ {
+ /* The register was saved on the stack, fetch it. */
+ *optimizedp = 0;
+ *lvalp = lval_memory;
+ *addrp = this_saved_regs[regnum].addr;
+ *realnump = -1;
+ if (bufferp != NULL)
+ {
+ /* Read the value in from memory. */
+ get_frame_memory (next_frame, this_saved_regs[regnum].addr, bufferp,
+ register_size (gdbarch, regnum));
+ }
+ }
+ else if (this_saved_regs[regnum].regnum >= 0
+ && this_saved_regs[regnum].addr == 0)
+ {
+ /* As the next frame to return the value of the register. */
+ frame_register_unwind (next_frame, this_saved_regs[regnum].regnum,
+ optimizedp, lvalp, addrp, realnump, bufferp);
+ }
+ else
+ {
+ /* The register's value is available. */
+ *optimizedp = 0;
+ *lvalp = not_lval;
+ *addrp = 0;
+ *realnump = -1;
+ if (bufferp != NULL)
+ store_unsigned_integer (bufferp, register_size (gdbarch, regnum),
+ this_saved_regs[regnum].addr);
+ }
+}
Index: trad-frame.h
===================================================================
RCS file: trad-frame.h
diff -N trad-frame.h
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ trad-frame.h 8 Jun 2003 16:04:02 -0000
@@ -0,0 +1,56 @@
+/* Traditional frame unwind support, for GDB the GNU Debugger.
+
+ Copyright 2003 Free Software Foundation, Inc.
+
+ This file is part of GDB.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 59 Temple Place - Suite 330,
+ Boston, MA 02111-1307, USA. */
+
+#ifndef TRAD_FRAME_H
+#define TRAD_FRAME_H
+
+struct trad_frame
+{
+ /* If non-zero (and regnum >= 0), the stack address at which the
+ register is saved. By default, it is assumed that the register
+ was not saved (addr == 0). Remember, a LONGEST can always fit a
+ CORE_ADDR. */
+ LONGEST addr;
+ /* else, if regnum >=0 (and addr == 0), the REGNUM that contains
+ this registers value. By default, it is assumed that the
+ registers are not moved (the register's value is still in that
+ register and regnum == the index). */
+ int regnum;
+ /* else, if regnum < 0, ADDR is the registers value. */
+};
+
+/* Convenience function, encode the register's value in the
+ trad-frame. */
+void trad_frame_register_value (struct trad_frame this_saved_regs[],
+ int regnum, LONGEST val);
+
+/* Return a freshly allocated (and initialized) trad_frame array. */
+struct trad_frame *trad_frame_alloc_saved_regs (struct frame_info *next_frame);
+
+/* Given the trad_frame info, return the location of the specified
+ register. */
+void trad_frame_prev_register (struct frame_info *next_frame,
+ struct trad_frame this_saved_regs[],
+ int regnum, int *optimizedp,
+ enum lval_type *lvalp, CORE_ADDR *addrp,
+ int *realnump, void *bufferp);
+
+#endif
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [commit] Split d10v-tdep.c into trad-frame.[hc]
2003-06-08 16:15 [commit] Split d10v-tdep.c into trad-frame.[hc] Andrew Cagney
@ 2003-06-08 16:58 ` Daniel Jacobowitz
2003-06-08 17:45 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-06-08 16:58 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches
On Sun, Jun 08, 2003 at 12:15:31PM -0400, Andrew Cagney wrote:
> Hello,
>
> This moves a chunk of d10v's frame unwind code into trad-frame.[hc]. It
> creates a simple framework that traditional unwinders can use - a
> successor to get_frame_saved_regs().
>
> Handling the problem of the previous frame's PC being in this frame's LR
> is remarkably simple - just copy the saved location of LR into PC!
I like it. Just one complaint:
> +struct trad_frame
> +{
> + /* If non-zero (and regnum >= 0), the stack address at which the
> + register is saved. By default, it is assumed that the register
> + was not saved (addr == 0). Remember, a LONGEST can always fit a
> + CORE_ADDR. */
> + LONGEST addr;
> + /* else, if regnum >=0 (and addr == 0), the REGNUM that contains
> + this registers value. By default, it is assumed that the
> + registers are not moved (the register's value is still in that
> + register and regnum == the index). */
> + int regnum;
> + /* else, if regnum < 0, ADDR is the registers value. */
> +};
Gyuh? I looked at this for a couple of minutes and couldn't make heads
or tails of it until I went to look at trad-frame.c: this structure
isn't a frame at all, it's a single saved register. Could you rename
it, and update the comments?
I'm also not sure I understand all the combinations:
regnum < 0, addr is the register value
regnum >= 0 and addr 0, regnum holds the new register number (in the
next frame?)
regnum >= 0 and addr non-zero, addr is the save address - but what's
regnum mean? Nothing?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [commit] Split d10v-tdep.c into trad-frame.[hc]
2003-06-08 16:58 ` Daniel Jacobowitz
@ 2003-06-08 17:45 ` Andrew Cagney
2003-06-08 17:48 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2003-06-08 17:45 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches
>> +struct trad_frame
trad_frame_saved_regs?
>> +{
>> + /* If non-zero (and regnum >= 0), the stack address at which the
>> + register is saved. By default, it is assumed that the register
>> + was not saved (addr == 0). Remember, a LONGEST can always fit a
>> + CORE_ADDR. */
>> + LONGEST addr;
>> + /* else, if regnum >=0 (and addr == 0), the REGNUM that contains
>> + this registers value. By default, it is assumed that the
>> + registers are not moved (the register's value is still in that
>> + register and regnum == the index). */
>> + int regnum;
>> + /* else, if regnum < 0, ADDR is the registers value. */
>> +};
>
>
> Gyuh? I looked at this for a couple of minutes and couldn't make heads
> or tails of it until I went to look at trad-frame.c: this structure
> isn't a frame at all, it's a single saved register. Could you rename
> it, and update the comments?
>
> I'm also not sure I understand all the combinations:
> regnum < 0, addr is the register value
> regnum >= 0 and addr 0, regnum holds the new register number (in the
> next frame?)
The previous frame's register is found in REGNUM in this frame. Need to
unwind the next frame's REGNUM to get the value of register REGNUM in
this frame.
> regnum >= 0 and addr non-zero, addr is the save address - but what's
> regnum mean? Nothing?
Nothing.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [commit] Split d10v-tdep.c into trad-frame.[hc]
2003-06-08 17:45 ` Andrew Cagney
@ 2003-06-08 17:48 ` Daniel Jacobowitz
2003-06-08 22:07 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-06-08 17:48 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches
On Sun, Jun 08, 2003 at 01:45:06PM -0400, Andrew Cagney wrote:
>
> >>+struct trad_frame
>
> trad_frame_saved_regs?
trad_frame_saved_reg? Even if you'll only ever use this as an array,
the structure is a singular register.
> >>+{
> >>+ /* If non-zero (and regnum >= 0), the stack address at which the
> >>+ register is saved. By default, it is assumed that the register
> >>+ was not saved (addr == 0). Remember, a LONGEST can always fit a
> >>+ CORE_ADDR. */
> >>+ LONGEST addr;
> >>+ /* else, if regnum >=0 (and addr == 0), the REGNUM that contains
> >>+ this registers value. By default, it is assumed that the
> >>+ registers are not moved (the register's value is still in that
> >>+ register and regnum == the index). */
> >>+ int regnum;
> >>+ /* else, if regnum < 0, ADDR is the registers value. */
> >>+};
> >
> >
> >Gyuh? I looked at this for a couple of minutes and couldn't make heads
> >or tails of it until I went to look at trad-frame.c: this structure
> >isn't a frame at all, it's a single saved register. Could you rename
> >it, and update the comments?
> >
> >I'm also not sure I understand all the combinations:
> > regnum < 0, addr is the register value
> > regnum >= 0 and addr 0, regnum holds the new register number (in the
> > next frame?)
>
> The previous frame's register is found in REGNUM in this frame. Need to
> unwind the next frame's REGNUM to get the value of register REGNUM in
> this frame.
The third REGNUM there means the array index, not the REGNUM member,
right?
> > regnum >= 0 and addr non-zero, addr is the save address - but what's
> > regnum mean? Nothing?
>
> Nothing.
OK, I see. I'd appreciate it if you clarified that in the comment.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [commit] Split d10v-tdep.c into trad-frame.[hc]
2003-06-08 17:48 ` Daniel Jacobowitz
@ 2003-06-08 22:07 ` Andrew Cagney
2003-06-08 22:12 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2003-06-08 22:07 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
> On Sun, Jun 08, 2003 at 01:45:06PM -0400, Andrew Cagney wrote:
>
>>
>
>> >>+struct trad_frame
>
>>
>> trad_frame_saved_regs?
I've changed it to the attached.
committed,
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 6445 bytes --]
2003-06-08 Andrew Cagney <cagney@redhat.com>
* trad-frame.h (struct trad_frame_saved_reg): Rename "struct
trad_frame". Update comments.
* d10v-tdep.c (struct d10v_unwind_cache): Update.
* trad-frame.c (trad_frame_alloc_saved_regs): Update.
(trad_frame_register_value, trad_frame_prev_register): Update.
Index: d10v-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/d10v-tdep.c,v
retrieving revision 1.121
diff -u -r1.121 d10v-tdep.c
--- d10v-tdep.c 8 Jun 2003 18:27:13 -0000 1.121
+++ d10v-tdep.c 8 Jun 2003 22:01:48 -0000
@@ -577,7 +577,7 @@
LONGEST r11_offset;
int uses_frame;
/* Table indicating the location of each and every register. */
- struct trad_frame *saved_regs;
+ struct trad_frame_saved_reg *saved_regs;
};
static int
Index: trad-frame.c
===================================================================
RCS file: /cvs/src/src/gdb/trad-frame.c,v
retrieving revision 1.1
diff -u -r1.1 trad-frame.c
--- trad-frame.c 8 Jun 2003 16:09:46 -0000 1.1
+++ trad-frame.c 8 Jun 2003 22:01:48 -0000
@@ -29,41 +29,41 @@
non-optimized frames, the technique is reliable (just need to check
for all potential instruction sequences). */
-struct trad_frame *
+struct trad_frame_saved_reg *
trad_frame_alloc_saved_regs (struct frame_info *next_frame)
{
- int i;
+ int regnum;
struct gdbarch *gdbarch = get_frame_arch (next_frame);
int numregs = NUM_REGS + NUM_PSEUDO_REGS;
- struct trad_frame *this_saved_regs
- = FRAME_OBSTACK_CALLOC (numregs, struct trad_frame);
- for (i = 0; i < numregs; i++)
- this_saved_regs[i].regnum = i;
+ struct trad_frame_saved_reg *this_saved_regs
+ = FRAME_OBSTACK_CALLOC (numregs, struct trad_frame_saved_reg);
+ for (regnum = 0; regnum < numregs; regnum++)
+ this_saved_regs[regnum].realnum = regnum;
return this_saved_regs;
}
void
-trad_frame_register_value (struct trad_frame this_saved_regs[],
+trad_frame_register_value (struct trad_frame_saved_reg this_saved_regs[],
int regnum, LONGEST val)
{
- /* Make the REGNUM invalid, indicating that the ADDR contains the
+ /* Make the REALNUM invalid, indicating that the ADDR contains the
register's value. */
- this_saved_regs[regnum].regnum = -1;
+ this_saved_regs[regnum].realnum = -1;
this_saved_regs[regnum].addr = val;
}
void
trad_frame_prev_register (struct frame_info *next_frame,
- struct trad_frame this_saved_regs[],
+ struct trad_frame_saved_reg this_saved_regs[],
int regnum, int *optimizedp,
enum lval_type *lvalp, CORE_ADDR *addrp,
int *realnump, void *bufferp)
{
struct gdbarch *gdbarch = get_frame_arch (next_frame);
- if (this_saved_regs[regnum].regnum >= 0
+ if (this_saved_regs[regnum].realnum >= 0
&& this_saved_regs[regnum].addr != 0)
{
- /* The register was saved on the stack, fetch it. */
+ /* The register was saved in memory. */
*optimizedp = 0;
*lvalp = lval_memory;
*addrp = this_saved_regs[regnum].addr;
@@ -75,11 +75,11 @@
register_size (gdbarch, regnum));
}
}
- else if (this_saved_regs[regnum].regnum >= 0
+ else if (this_saved_regs[regnum].realnum >= 0
&& this_saved_regs[regnum].addr == 0)
{
/* As the next frame to return the value of the register. */
- frame_register_unwind (next_frame, this_saved_regs[regnum].regnum,
+ frame_register_unwind (next_frame, this_saved_regs[regnum].realnum,
optimizedp, lvalp, addrp, realnump, bufferp);
}
else
Index: trad-frame.h
===================================================================
RCS file: /cvs/src/src/gdb/trad-frame.h,v
retrieving revision 1.1
diff -u -r1.1 trad-frame.h
--- trad-frame.h 8 Jun 2003 16:09:46 -0000 1.1
+++ trad-frame.h 8 Jun 2003 22:01:48 -0000
@@ -22,33 +22,45 @@
#ifndef TRAD_FRAME_H
#define TRAD_FRAME_H
-struct trad_frame
+/* A traditional saved regs table, indexed by REGNUM, encoding where
+ the value of REGNUM for the previous frame can be found in this
+ frame.
+
+ The table is initialized with an identity encoding (ADDR == 0,
+ REALNUM == REGNUM) indicating that the value of REGNUM in the
+ previous frame can be found in register REGNUM (== REALNUM) in this
+ frame.
+
+ The initial encoding can then be changed:
+
+ Modify ADDR (REALNUM >= 0, ADDR != 0) to indicate that the value of
+ register REGNUM in the previous frame can be found in memory at
+ ADDR in this frame.
+
+ Modify REALNUM (REALNUM >= 0, ADDR == 0) to indicate that the value
+ of register REGNUM in the previous frame is found in register
+ REALNUM in this frame.
+
+ Call trad_frame_register_value (REALNUM < 0) to indicate that the
+ value of register REGNUM in the previous frame is found in ADDR. */
+
+struct trad_frame_saved_reg
{
- /* If non-zero (and regnum >= 0), the stack address at which the
- register is saved. By default, it is assumed that the register
- was not saved (addr == 0). Remember, a LONGEST can always fit a
- CORE_ADDR. */
- LONGEST addr;
- /* else, if regnum >=0 (and addr == 0), the REGNUM that contains
- this registers value. By default, it is assumed that the
- registers are not moved (the register's value is still in that
- register and regnum == the index). */
- int regnum;
- /* else, if regnum < 0, ADDR is the registers value. */
+ LONGEST addr; /* A CORE_ADDR fits in a longest. */
+ int realnum;
};
-/* Convenience function, encode the register's value in the
- trad-frame. */
-void trad_frame_register_value (struct trad_frame this_saved_regs[],
+/* Convenience function, encode REGNUM's location in the trad-frame. */
+void trad_frame_register_value (struct trad_frame_saved_reg this_saved_regs[],
int regnum, LONGEST val);
/* Return a freshly allocated (and initialized) trad_frame array. */
-struct trad_frame *trad_frame_alloc_saved_regs (struct frame_info *next_frame);
+struct trad_frame_saved_reg *trad_frame_alloc_saved_regs (struct frame_info *next_frame);
/* Given the trad_frame info, return the location of the specified
register. */
void trad_frame_prev_register (struct frame_info *next_frame,
- struct trad_frame this_saved_regs[],
+ struct trad_frame_saved_reg this_saved_regs[],
int regnum, int *optimizedp,
enum lval_type *lvalp, CORE_ADDR *addrp,
int *realnump, void *bufferp);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [commit] Split d10v-tdep.c into trad-frame.[hc]
2003-06-08 22:07 ` Andrew Cagney
@ 2003-06-08 22:12 ` Daniel Jacobowitz
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-06-08 22:12 UTC (permalink / raw)
To: gdb-patches
On Sun, Jun 08, 2003 at 06:07:35PM -0400, Andrew Cagney wrote:
> >On Sun, Jun 08, 2003 at 01:45:06PM -0400, Andrew Cagney wrote:
> >
> >>
> >
> >>>>+struct trad_frame
> >
> >>
> >>trad_frame_saved_regs?
>
> I've changed it to the attached.
Thanks! I see how it works now.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-06-08 22:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-08 16:15 [commit] Split d10v-tdep.c into trad-frame.[hc] Andrew Cagney
2003-06-08 16:58 ` Daniel Jacobowitz
2003-06-08 17:45 ` Andrew Cagney
2003-06-08 17:48 ` Daniel Jacobowitz
2003-06-08 22:07 ` Andrew Cagney
2003-06-08 22:12 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox