[PATCH] Fix x86_64_fill_fxsave()

[PATCH] Fix x86_64_fill_fxsave()

[Michal Ludvig]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

Hi,
attached is a patch for x86_64_fill_fxsave(). Originally it sometimes 
passed regno == -1 to regcache_collect which triggered GDB internal 
error. Now it passes correct values.

Committed as obvious.

Michal Ludvig

[-- Attachment #2: fxsave-1.diff --]
[-- Type: text/plain, Size: 826 bytes --]

2003-06-06  Michal Ludvig  <mludvig@suse.cz>

	* x86-64-tdep.c (x86_64_fill_fxsave): Pass correct regnums 
	to regcache_collect().

Index: x86-64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v
retrieving revision 1.76
diff -u -p -r1.76 x86-64-tdep.c
--- x86-64-tdep.c	5 Jun 2003 18:54:34 -0000	1.76
+++ x86-64-tdep.c	6 Jun 2003 10:02:42 -0000
@@ -1246,7 +1246,7 @@ x86_64_fill_fxsave (char *fxsave, int re
   i387_fill_fxsave (fxsave, regnum);
 
   if (regnum == -1 || regnum == I387_FISEG_REGNUM)
-    regcache_collect (regnum, fxsave + 12);
+    regcache_collect (I387_FISEG_REGNUM, fxsave + 12);
   if (regnum == -1 || regnum == I387_FOSEG_REGNUM)
-    regcache_collect (regnum, fxsave + 20);
+    regcache_collect (I387_FOSEG_REGNUM, fxsave + 20);
 }

Re: [PATCH] Fix x86_64_fill_fxsave()

[Andreas Jaeger]

Michal Ludvig <mludvig@suse.cz> writes:

> Hi,
> attached is a patch for x86_64_fill_fxsave(). Originally it sometimes
> passed regno == -1 to regcache_collect which triggered GDB internal
> error. Now it passes correct values.

Yeah, now the testsuite failures are down from 180 a few days ago to
108!

Thanks,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj