From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2398 invoked by alias); 6 Jun 2003 10:07:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2319 invoked from network); 6 Jun 2003 10:07:03 -0000 Received: from unknown (HELO maxipes.logix.cz) (81.0.234.97) by sources.redhat.com with SMTP; 6 Jun 2003 10:07:03 -0000 Received: from suse.cz (Charybdis.suse.de [213.95.15.201]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client did not present a certificate) by maxipes.logix.cz (Postfix) with ESMTP id A16892A14F for ; Fri, 6 Jun 2003 12:07:02 +0200 (CEST) Message-ID: <3EE067C5.2000001@suse.cz> Date: Fri, 06 Jun 2003 10:07:00 -0000 From: Michal Ludvig User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030529 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [PATCH] Fix x86_64_fill_fxsave() Content-Type: multipart/mixed; boundary="------------060206030505050308050307" X-SW-Source: 2003-06/txt/msg00227.txt.bz2 This is a multi-part message in MIME format. --------------060206030505050308050307 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 219 Hi, attached is a patch for x86_64_fill_fxsave(). Originally it sometimes passed regno == -1 to regcache_collect which triggered GDB internal error. Now it passes correct values. Committed as obvious. Michal Ludvig --------------060206030505050308050307 Content-Type: text/plain; name="fxsave-1.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fxsave-1.diff" Content-length: 826 2003-06-06 Michal Ludvig * x86-64-tdep.c (x86_64_fill_fxsave): Pass correct regnums to regcache_collect(). Index: x86-64-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v retrieving revision 1.76 diff -u -p -r1.76 x86-64-tdep.c --- x86-64-tdep.c 5 Jun 2003 18:54:34 -0000 1.76 +++ x86-64-tdep.c 6 Jun 2003 10:02:42 -0000 @@ -1246,7 +1246,7 @@ x86_64_fill_fxsave (char *fxsave, int re i387_fill_fxsave (fxsave, regnum); if (regnum == -1 || regnum == I387_FISEG_REGNUM) - regcache_collect (regnum, fxsave + 12); + regcache_collect (I387_FISEG_REGNUM, fxsave + 12); if (regnum == -1 || regnum == I387_FOSEG_REGNUM) - regcache_collect (regnum, fxsave + 20); + regcache_collect (I387_FOSEG_REGNUM, fxsave + 20); } --------------060206030505050308050307--