[RFA] Add missing struct gdbarch opaque def to frame.h

[RFA] Add missing struct gdbarch opaque def to frame.h

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

Hello,

    http://sources.redhat.com/ml/gdb-patches/2003-04/msg00173.html

There is a compilation warning when building on LynxOS 4.0. The
following patch fixes it.

2003-04-09  J. Brobecker  <brobecker@gnat.com>

        * frame.h (struct gdbarch): Add opaque structure definition
        to avoid a compilation warning on LynxOS 4.0.

Ok to apply, I guess?

Thanks,
-- 
Joel

[-- Attachment #2: frame.h.diff --]
[-- Type: text/plain, Size: 501 bytes --]

Index: frame.h
===================================================================
RCS file: /cvs/src/src/gdb/frame.h,v
retrieving revision 1.85
diff -c -3 -p -r1.85 frame.h
*** frame.h	6 Apr 2003 18:36:23 -0000	1.85
--- frame.h	9 Apr 2003 20:59:06 -0000
*************** struct symtab_and_line;
*** 27,32 ****
--- 27,33 ----
  struct frame_unwind;
  struct frame_base;
  struct block;
+ struct gdbarch;
  
  /* A legacy unwinder to prop up architectures using the old style
     saved regs array.  */

Re: [RFA] Add missing struct gdbarch opaque def to frame.h

[Andrew Cagney]

> 2003-04-09  J. Brobecker  <brobecker@gnat.com>
> 
>         * frame.h (struct gdbarch): Add opaque structure definition
>         to avoid a compilation warning on LynxOS 4.0.
> 
> Ok to apply, I guess?

Yes, obvious.  Does this mean I can't delete LynxOS?

> Index: frame.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/frame.h,v
> retrieving revision 1.85
> diff -c -3 -p -r1.85 frame.h
> *** frame.h	6 Apr 2003 18:36:23 -0000	1.85
> --- frame.h	9 Apr 2003 20:59:06 -0000
> *************** struct symtab_and_line;
> *** 27,32 ****
> --- 27,33 ----
>   struct frame_unwind;
>   struct frame_base;
>   struct block;
> + struct gdbarch;
>   
>   /* A legacy unwinder to prop up architectures using the old style
>      saved regs array.  */

Re: [RFA] Add missing struct gdbarch opaque def to frame.h

[Joel Brobecker]

> >2003-04-09  J. Brobecker  <brobecker@gnat.com>
> >
> >        * frame.h (struct gdbarch): Add opaque structure definition
> >        to avoid a compilation warning on LynxOS 4.0.
> 
> Yes, obvious.  Does this mean I can't delete LynxOS?

Thanks, it's in. 

As for deleting LynxOS, I can't really make a comment about that just
yet. I am still at the experimenting stage trying to build the x86-lynx
native version, see what I get. MarkK might want to comment about this
too. 

It looks like there has been very little activity happening on this
port, and the code also seems to have suffered from bitrot, so I am not
sure what is best at this point: 
  - start over from scratch
  - start from what we have, and bring the LynxOS port back afloat.

I only have until tonight to get it to build. I will send a note to this
list summarizing a bit what I did.

-- 
Joel