[RFA] Dummy frames on x86-64

[Michal Ludvig <mludvig@suse.cz>]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Andrew Cagney wrote:
>> +static void
>> +x86_64_save_dummy_frame_tos (CORE_ADDR sp)
>> +{
>> +  /* We must add the size of the return address that is already
>> +     put on the stack.  */
>> +  generic_save_dummy_frame_tos (sp + sizeof(CORE_ADDR));
> 
> Yes, but use TYPE_LENGTH (builtin_type_void_{code/data}_ptr).

Great, thanks for your help!
Can I commit the attached patch to mainline, please?

Michal Ludvig
-- 
* SuSE CR, s.r.o     * mludvig@suse.cz
* (+420) 296.545.373 * http://www.suse.cz

[-- Attachment #2: dummy-unwind-1.diff --]
[-- Type: text/plain, Size: 1561 bytes --]

2002-03-06  Michal Ludvig  <mludvig@suse.cz>

	* x86-64-tdep.c (x86_64_save_dummy_frame_tos)
	(x86_64_unwind_dummy_id): New functions.
	(x86_64_init_abi): Register these two new functions.

Index: x86-64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v
retrieving revision 1.51
diff -u -p -r1.51 x86-64-tdep.c
--- x86-64-tdep.c	2 Mar 2003 04:02:25 -0000	1.51
+++ x86-64-tdep.c	6 Mar 2003 22:38:14 -0000
@@ -913,6 +913,26 @@ x86_64_breakpoint_from_pc (CORE_ADDR *pc
   return breakpoint;
 }
 
+static void
+x86_64_save_dummy_frame_tos (CORE_ADDR sp)
+{
+  /* We must add the size of the return address that is already 
+     put on the stack.  */
+  generic_save_dummy_frame_tos (sp + 
+				TYPE_LENGTH (builtin_type_void_func_ptr));
+}
+
+static struct frame_id
+x86_64_unwind_dummy_id (struct gdbarch *gdbarch, struct frame_info *frame)
+{
+  struct frame_id id;
+  
+  id.pc = frame_pc_unwind (frame);
+  frame_unwind_unsigned_register (frame, SP_REGNUM, &id.base);
+
+  return id;
+}
+
 void
 x86_64_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
 {
@@ -1023,6 +1043,10 @@ x86_64_init_abi (struct gdbarch_info inf
      since all supported x86-64 targets are ELF, but that might change
      in the future.  */
   set_gdbarch_in_solib_call_trampoline (gdbarch, in_plt_section);
+  
+  /* Dummy frame helper functions.  */
+  set_gdbarch_save_dummy_frame_tos (gdbarch, x86_64_save_dummy_frame_tos);
+  set_gdbarch_unwind_dummy_id (gdbarch, x86_64_unwind_dummy_id);
 }
 
 void