[RFA]: Don't execute C++ tests for HC11/HC12

[RFA]: Don't execute C++ tests for HC11/HC12

[Stephane Carrez]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Hi!

The C++ IO streams are too large for HC11/HC12 and are thus not available.
The gdb C++ tests use them and don't compile.

Can you approve this patch to avoid executing the C++ tests for the m6811/m6812 targets?

Thanks,
	Stephane

2003-02-23  Stephane Carrez  <stcarrez@nerim.fr>

	* lib/gdb.exp: Don't execute C++ tests on m6811/m6812 targets.

[-- Attachment #2: gdb.exp.diffs --]
[-- Type: text/plain, Size: 514 bytes --]

Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.34
diff -u -p -r1.34 gdb.exp
--- lib/gdb.exp	31 Jan 2003 00:38:33 -0000	1.34
+++ lib/gdb.exp	23 Feb 2003 20:53:27 -0000
@@ -1004,6 +1004,12 @@ proc skip_cplus_tests {} {
     if { [istarget "h8300-*-*"] } {
 	return 1
     }
+    if { [istarget "m6811-*-*"] } {
+	return 1
+    }
+    if { [istarget "m6812-*-*"] } {
+	return 1
+    }
     return 0
 }
 

Re: [RFA]: Don't execute C++ tests for HC11/HC12

[Michael Elizabeth Chastain]

Hi Stephane,

I like this patch.  I need two things and then I will approve it.

> The C++ IO streams are too large for HC11/HC12 and are thus not available.
> The gdb C++ tests use them and don't compile.

Please add this note as a comment in skip_cplus_tests, for the
benefit of future maintainers.

Also tell me how you tested your patch.  I do not need an exhaustive test.
I just need you to describe whatever you did on your system to test
the patch.

Thanks,

Michael C

===

2003-02-23  Stephane Carrez  <stcarrez@nerim.fr>

	* lib/gdb.exp: Don't execute C++ tests on m6811/m6812 targets.

Re: [RFA]: Don't execute C++ tests for HC11/HC12

[Stephane Carrez]

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

Hi Michael,

Michael Elizabeth Chastain wrote:

> Hi Stephane,
> 
> I like this patch.  I need two things and then I will approve it.
> 
> 
>>The C++ IO streams are too large for HC11/HC12 and are thus not available.
>>The gdb C++ tests use them and don't compile.
>>
> 
> Please add this note as a comment in skip_cplus_tests, for the
> benefit of future maintainers.
> 
> Also tell me how you tested your patch.  I do not need an exhaustive test.
> I just need you to describe whatever you did on your system to test
> the patch.
> 


I'm running the full gdb validation with 'make check'.

(with gcc 3_3 branch and binutils main branch; configured with --target=m6811-elf).

Attached the new patch with the comment added.

	Stephane



[-- Attachment #2: gdb.exp.diffs --]
[-- Type: text/plain, Size: 652 bytes --]

Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.34
diff -u -p -r1.34 gdb.exp
--- lib/gdb.exp	31 Jan 2003 00:38:33 -0000	1.34
+++ lib/gdb.exp	23 Feb 2003 21:35:21 -0000
@@ -1004,6 +1004,15 @@ proc skip_cplus_tests {} {
     if { [istarget "h8300-*-*"] } {
 	return 1
     }
+
+    # The C++ IO streams are too large for HC11/HC12 and are thus not
+    # available.  The gdb C++ tests use them and don't compile.
+    if { [istarget "m6811-*-*"] } {
+	return 1
+    }
+    if { [istarget "m6812-*-*"] } {
+	return 1
+    }
     return 0
 }
 

Re: [RFA]: Don't execute C++ tests for HC11/HC12

[Michael Elizabeth Chastain]

Beautiful!  This patch is approved.

Michael C

2003-02-23  Stephane Carrez  <stcarrez@nerim.fr>

	* lib/gdb.exp: Don't execute C++ tests on m6811/m6812 targets.