From: Stephane Carrez <stcarrez@nerim.fr>
To: Michael Elizabeth Chastain <mec@shout.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Don't execute C++ tests for HC11/HC12
Date: Sun, 23 Feb 2003 21:43:00 -0000 [thread overview]
Message-ID: <3E594075.3050705@nerim.fr> (raw)
In-Reply-To: <200302232110.h1NLAhi01353@duracef.shout.net>
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
Hi Michael,
Michael Elizabeth Chastain wrote:
> Hi Stephane,
>
> I like this patch. I need two things and then I will approve it.
>
>
>>The C++ IO streams are too large for HC11/HC12 and are thus not available.
>>The gdb C++ tests use them and don't compile.
>>
>
> Please add this note as a comment in skip_cplus_tests, for the
> benefit of future maintainers.
>
> Also tell me how you tested your patch. I do not need an exhaustive test.
> I just need you to describe whatever you did on your system to test
> the patch.
>
I'm running the full gdb validation with 'make check'.
(with gcc 3_3 branch and binutils main branch; configured with --target=m6811-elf).
Attached the new patch with the comment added.
Stephane
[-- Attachment #2: gdb.exp.diffs --]
[-- Type: text/plain, Size: 652 bytes --]
Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.34
diff -u -p -r1.34 gdb.exp
--- lib/gdb.exp 31 Jan 2003 00:38:33 -0000 1.34
+++ lib/gdb.exp 23 Feb 2003 21:35:21 -0000
@@ -1004,6 +1004,15 @@ proc skip_cplus_tests {} {
if { [istarget "h8300-*-*"] } {
return 1
}
+
+ # The C++ IO streams are too large for HC11/HC12 and are thus not
+ # available. The gdb C++ tests use them and don't compile.
+ if { [istarget "m6811-*-*"] } {
+ return 1
+ }
+ if { [istarget "m6812-*-*"] } {
+ return 1
+ }
return 0
}
next prev parent reply other threads:[~2003-02-23 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-23 21:10 Michael Elizabeth Chastain
2003-02-23 21:43 ` Stephane Carrez [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-02-23 22:00 Michael Elizabeth Chastain
2003-02-23 20:59 Stephane Carrez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E594075.3050705@nerim.fr \
--to=stcarrez@nerim.fr \
--cc=gdb-patches@sources.redhat.com \
--cc=mec@shout.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox