From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFC/gdbarch: Make OS ABI a real member of the gdbarch
Date: Fri, 03 Jan 2003 22:15:00 -0000 [thread overview]
Message-ID: <3E160B86.4030201@redhat.com> (raw)
In-Reply-To: <20021228001850.GA2127@nevyn.them.org>
> +#
> +i:2:TARGET_OSABI:enum gdb_osabi:osabi::::GDB_OSABI_UNKNOWN
Yes, much better.
> +enum gdb_osabi
> +{
> + GDB_OSABI_UNINITIALIZED = -1, /* For struct gdbarch_info. */
> +
> + GDB_OSABI_UNKNOWN = 0, /* keep this zero */
I belive that both of these `= ...' can be dropped - since info.osabi is
explicitly initialized, no magic values are needed. This is also more
consistent with it being a named enum.
Hmm, why was the enum to a new file? Ah! Ulgh, "gdbarch.h" needs the
definition :-/ Rather than create a new file, just move the enum to
"defs.h". This is consistent with other, similar, enums solved the
problem. It also stops me thinking that "osabi.h" should include
"osabi-list.h" (nb, s/_/-/) :-)
enjoy,
Andrew
next prev parent reply other threads:[~2003-01-03 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-27 16:34 Daniel Jacobowitz
2002-12-28 5:13 ` Mark Kettenis
2003-01-03 22:15 ` Andrew Cagney [this message]
2003-01-04 23:37 ` Daniel Jacobowitz
2003-01-06 20:28 ` Andrew Cagney
2003-01-07 22:23 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E160B86.4030201@redhat.com \
--to=ac131313@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox