From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10192 invoked by alias); 3 Jan 2003 22:15:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10168 invoked from network); 3 Jan 2003 22:15:46 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by 209.249.29.67 with SMTP; 3 Jan 2003 22:15:46 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 67BAD3DC2; Fri, 3 Jan 2003 17:15:34 -0500 (EST) Message-ID: <3E160B86.4030201@redhat.com> Date: Fri, 03 Jan 2003 22:15:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: RFC/gdbarch: Make OS ABI a real member of the gdbarch References: <20021228001850.GA2127@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-01/txt/msg00105.txt.bz2 > +# > +i:2:TARGET_OSABI:enum gdb_osabi:osabi::::GDB_OSABI_UNKNOWN Yes, much better. > +enum gdb_osabi > +{ > + GDB_OSABI_UNINITIALIZED = -1, /* For struct gdbarch_info. */ > + > + GDB_OSABI_UNKNOWN = 0, /* keep this zero */ I belive that both of these `= ...' can be dropped - since info.osabi is explicitly initialized, no magic values are needed. This is also more consistent with it being a named enum. Hmm, why was the enum to a new file? Ah! Ulgh, "gdbarch.h" needs the definition :-/ Rather than create a new file, just move the enum to "defs.h". This is consistent with other, similar, enums solved the problem. It also stops me thinking that "osabi.h" should include "osabi-list.h" (nb, s/_/-/) :-) enjoy, Andrew