From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: RFC/gdbarch: Make OS ABI a real member of the gdbarch
Date: Tue, 07 Jan 2003 22:23:00 -0000 [thread overview]
Message-ID: <20030107222319.GA20617@nevyn.them.org> (raw)
In-Reply-To: <3E19E6C8.50805@redhat.com>
On Mon, Jan 06, 2003 at 03:27:52PM -0500, Andrew Cagney wrote:
> >I belive that both of these `= ...' can be dropped - since info.osabi is
> >>explicitly initialized, no magic values are needed. This is also more
> >>consistent with it being a named enum.
> >
> >
> >Probably, but it's a little tricky; it's used to index an array, check
> >various bounds, etc. I'm going to leave that be for now.
>
> Ok, don't forget to clean this up though.
Well, I'd rather not. When this code was added, someone more familiar
with it than I am added the /* keep this zero */ comment. There's a
couple of subtleties in changing the value, and no benefit.
If it really bugs you let me know and I'll look closer.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2003-01-07 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-27 16:34 Daniel Jacobowitz
2002-12-28 5:13 ` Mark Kettenis
2003-01-03 22:15 ` Andrew Cagney
2003-01-04 23:37 ` Daniel Jacobowitz
2003-01-06 20:28 ` Andrew Cagney
2003-01-07 22:23 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030107222319.GA20617@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox