From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31679 invoked by alias); 7 Jan 2003 22:23:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31662 invoked from network); 7 Jan 2003 22:23:11 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 209.249.29.67 with SMTP; 7 Jan 2003 22:23:11 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18W40Q-0006mW-00 for ; Tue, 07 Jan 2003 18:23:38 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18W27z-0005NN-00 for ; Tue, 07 Jan 2003 17:23:19 -0500 Date: Tue, 07 Jan 2003 22:23:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: RFC/gdbarch: Make OS ABI a real member of the gdbarch Message-ID: <20030107222319.GA20617@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20021228001850.GA2127@nevyn.them.org> <3E160B86.4030201@redhat.com> <20030104233734.GF28756@nevyn.them.org> <3E19E6C8.50805@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E19E6C8.50805@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00294.txt.bz2 On Mon, Jan 06, 2003 at 03:27:52PM -0500, Andrew Cagney wrote: > >I belive that both of these `= ...' can be dropped - since info.osabi is > >>explicitly initialized, no magic values are needed. This is also more > >>consistent with it being a named enum. > > > > > >Probably, but it's a little tricky; it's used to index an array, check > >various bounds, etc. I'm going to leave that be for now. > > Ok, don't forget to clean this up though. Well, I'd rather not. When this code was added, someone more familiar with it than I am added the /* keep this zero */ comment. There's a couple of subtleties in changing the value, and no benefit. If it really bugs you let me know and I'll look closer. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer