From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Michael Snyder <msnyder@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: PATCH/RFC: Bring lin-lwp performance back to the real world
Date: Fri, 22 Nov 2002 14:23:00 -0000 [thread overview]
Message-ID: <3DDEAE47.30007@redhat.com> (raw)
In-Reply-To: <20021122214955.GA23497@nevyn.them.org>
> +#ifdef HAVE_PREAD64
> + if (pread64 (fd, myaddr, len, addr) != len)
> +#else
> + if (lseek (fd, addr, SEEK_SET) == -1
> + || read (fd, myaddr, len) != len)
> +#endif
Suggest a comment explaining the rationale behind the choices and the
need for those -D flags here.
Andrew
next prev parent reply other threads:[~2002-11-22 22:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-21 20:11 Daniel Jacobowitz
2002-11-21 20:51 ` Andrew Cagney
2002-11-21 21:02 ` Andrew Cagney
2002-11-21 21:29 ` Daniel Jacobowitz
2002-11-21 21:57 ` Andrew Cagney
2002-11-22 10:58 ` Michael Snyder
2002-11-22 12:34 ` Daniel Jacobowitz
2002-11-22 13:49 ` Daniel Jacobowitz
2002-11-22 14:23 ` Andrew Cagney [this message]
2002-11-25 17:33 ` Daniel Jacobowitz
2002-11-26 7:05 ` Andrew Cagney
2002-11-22 10:57 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DDEAE47.30007@redhat.com \
--to=ac131313@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox