Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH/RFC: Bring lin-lwp performance back to the real world
Date: Thu, 21 Nov 2002 21:57:00 -0000	[thread overview]
Message-ID: <3DDDC753.2010205@redhat.com> (raw)
In-Reply-To: <20021122052939.GA26668@nevyn.them.org>

> 
> Hrm, possibly.  I needed to create linux-nat.c anyway (I'll need it for
> some things that are definitely not /proc related) but I could be
> persuaded either way on linux_proc_xfer_memory.  It's not focused on
> the "proc" bit as much as the "xfer" bit, but it's definitely using
> /proc.  If you prefer I'll move it, and save linux-nat.c for another
> patch.

Not really my problem (It's a linux / lin-lwp area).  I just figure 
that, if you put it in linux-proc.c, you've a more compelling argument 
for getting the change into 5.3 (as if I'm going to stand in its way :-):

- linux-proc.c provides you with the `prior art'.  The other code in 
that file is pulling an identical trick - using /proc when it should 
really be using ptrace().

- it trims the change back to something more managable (all the config 
parts go) so it is easier to be sure it's right.

enjoy,
Andrew



  reply	other threads:[~2002-11-22  5:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-21 20:11 Daniel Jacobowitz
2002-11-21 20:51 ` Andrew Cagney
2002-11-21 21:02   ` Andrew Cagney
2002-11-21 21:29   ` Daniel Jacobowitz
2002-11-21 21:57     ` Andrew Cagney [this message]
2002-11-22 10:58       ` Michael Snyder
2002-11-22 12:34         ` Daniel Jacobowitz
2002-11-22 13:49           ` Daniel Jacobowitz
2002-11-22 14:23             ` Andrew Cagney
2002-11-25 17:33             ` Daniel Jacobowitz
2002-11-26  7:05               ` Andrew Cagney
2002-11-22 10:57 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DDDC753.2010205@redhat.com \
    --to=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox