From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3948 invoked by alias); 22 Nov 2002 05:57:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3923 invoked from network); 22 Nov 2002 05:57:47 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 22 Nov 2002 05:57:47 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id D97F23E4B; Fri, 22 Nov 2002 00:57:39 -0500 (EST) Message-ID: <3DDDC753.2010205@redhat.com> Date: Thu, 21 Nov 2002 21:57:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH/RFC: Bring lin-lwp performance back to the real world References: <20021122041123.GA21389@nevyn.them.org> <3DDDB7B5.2070809@redhat.com> <20021122052939.GA26668@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-11/txt/msg00538.txt.bz2 > > Hrm, possibly. I needed to create linux-nat.c anyway (I'll need it for > some things that are definitely not /proc related) but I could be > persuaded either way on linux_proc_xfer_memory. It's not focused on > the "proc" bit as much as the "xfer" bit, but it's definitely using > /proc. If you prefer I'll move it, and save linux-nat.c for another > patch. Not really my problem (It's a linux / lin-lwp area). I just figure that, if you put it in linux-proc.c, you've a more compelling argument for getting the change into 5.3 (as if I'm going to stand in its way :-): - linux-proc.c provides you with the `prior art'. The other code in that file is pulling an identical trick - using /proc when it should really be using ptrace(). - it trims the change back to something more managable (all the config parts go) so it is easier to be sure it's right. enjoy, Andrew