From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1755 invoked by alias); 22 Nov 2002 22:23:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1746 invoked from network); 22 Nov 2002 22:23:09 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 22 Nov 2002 22:23:09 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 671063E66; Fri, 22 Nov 2002 17:23:03 -0500 (EST) Message-ID: <3DDEAE47.30007@redhat.com> Date: Fri, 22 Nov 2002 14:23:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: PATCH/RFC: Bring lin-lwp performance back to the real world References: <20021122041123.GA21389@nevyn.them.org> <3DDDB7B5.2070809@redhat.com> <20021122052939.GA26668@nevyn.them.org> <3DDDC753.2010205@redhat.com> <3DDE7E64.F9EC57A6@redhat.com> <20021122203413.GA18872@nevyn.them.org> <20021122214955.GA23497@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-11/txt/msg00562.txt.bz2 > +#ifdef HAVE_PREAD64 > + if (pread64 (fd, myaddr, len, addr) != len) > +#else > + if (lseek (fd, addr, SEEK_SET) == -1 > + || read (fd, myaddr, len) != len) > +#endif Suggest a comment explaining the rationale behind the choices and the need for those -D flags here. Andrew