From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Remove unnecessary zero-initializations
Date: Sun, 10 Nov 2002 20:09:00 -0000 [thread overview]
Message-ID: <3DCF2D6E.2030407@redhat.com> (raw)
In-Reply-To: <20021111001910.GA17944@nevyn.them.org>
> Currently, thirteen files which provide a target_ops explicitly initialize
> members they don't support to NULL. I plan to delete a number of these
> methods, and rather than making sure I got all the necessary target files
> each time I just wanted to delete the unnecessary lines up-front. All of
> these are called-once functions initializing a statically or globally
> declared object; C will guarantee zero-initialization for us. And several
> of the functions explicitly called memset anyway.
>
> Besides, this way grepping for .to_require_attach\ = will only find targets
> which define it to something useful.
>
> I'll commit this tomorrow unless someone sees a problem with it.
>
> Note1: remote-st.c hasn't been compilable in a while; m68*-tandem-* is
> probably a good candidate for the hitlist. From a glance it looks like it
> has been broken since the HP merge added the NULL assignments I'm removing,
> which is about three years now I think.
>
> Note2: The DONT_USE member of struct target_ops can go now.
The fact that 13 files were doing it should suggest that it was
intentional. Might want to wait a bit longer while someone dregs up the
history.
Andrew
next prev parent reply other threads:[~2002-11-11 4:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-10 16:18 Daniel Jacobowitz
2002-11-10 20:09 ` Andrew Cagney [this message]
2002-11-10 20:22 ` Daniel Jacobowitz
2002-12-19 15:51 ` Elena Zannoni
2002-12-19 15:59 ` Daniel Jacobowitz
2002-11-11 6:39 ` Elena Zannoni
2002-11-13 10:59 ` Michael Snyder
2002-11-13 11:32 ` Andrew Cagney
2002-11-13 11:50 ` Michael Snyder
2002-11-11 2:48 ` Felix Lee
2002-11-11 6:33 ` Daniel Jacobowitz
2002-11-11 17:15 ` Felix Lee
2002-11-12 13:44 ` Daniel Jacobowitz
2002-11-13 11:04 ` Michael Snyder
2002-11-13 11:38 ` Stan Shebs
2002-11-13 11:01 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DCF2D6E.2030407@redhat.com \
--to=ac131313@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox