Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Felix Lee <bdgle@tigerfood.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Remove unnecessary zero-initializations
Date: Wed, 13 Nov 2002 11:01:00 -0000	[thread overview]
Message-ID: <3DD2A17D.C770432A@redhat.com> (raw)
In-Reply-To: <200211111048.gABAmXr01641@paper-wolf-solo.tigerfood.org>

Felix Lee wrote:
> 
> Daniel Jacobowitz <drow@mvista.com>:
> > Currently, thirteen files which provide a target_ops explicitly initialize
> > members they don't support to NULL.
> 
> this is a style and readability issue.  if every set of
> initializations is complete and mentions all members, even
> when "unnecessary", then it's easier to quickly check that
> an implementation correctly matches the specification.  a
> statement like
>     foo.bar = 0;
> indicates that the programmer was aware that foo.bar exists,
> thought about it, and decided that 0 is a correct value.

This is counter to the intention.  We made the initializations
un-necessary on purpose, so that when a new target method gets
added, you don't have to go add a new " = NULL;" to every file
that doesn't implement it.


      parent reply	other threads:[~2002-11-13 19:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-10 16:18 Daniel Jacobowitz
2002-11-10 20:09 ` Andrew Cagney
2002-11-10 20:22   ` Daniel Jacobowitz
2002-12-19 15:51     ` Elena Zannoni
2002-12-19 15:59       ` Daniel Jacobowitz
2002-11-11  6:39   ` Elena Zannoni
2002-11-13 10:59   ` Michael Snyder
2002-11-13 11:32     ` Andrew Cagney
2002-11-13 11:50       ` Michael Snyder
2002-11-11  2:48 ` Felix Lee
2002-11-11  6:33   ` Daniel Jacobowitz
2002-11-11 17:15     ` Felix Lee
2002-11-12 13:44       ` Daniel Jacobowitz
2002-11-13 11:04       ` Michael Snyder
2002-11-13 11:38         ` Stan Shebs
2002-11-13 11:01   ` Michael Snyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DD2A17D.C770432A@redhat.com \
    --to=msnyder@redhat.com \
    --cc=bdgle@tigerfood.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox