From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17554 invoked by alias); 11 Nov 2002 04:09:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17546 invoked from network); 11 Nov 2002 04:09:19 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 11 Nov 2002 04:09:19 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1FE443D04; Sun, 10 Nov 2002 23:09:19 -0500 (EST) Message-ID: <3DCF2D6E.2030407@redhat.com> Date: Sun, 10 Nov 2002 20:09:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Remove unnecessary zero-initializations References: <20021111001910.GA17944@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-11/txt/msg00300.txt.bz2 > Currently, thirteen files which provide a target_ops explicitly initialize > members they don't support to NULL. I plan to delete a number of these > methods, and rather than making sure I got all the necessary target files > each time I just wanted to delete the unnecessary lines up-front. All of > these are called-once functions initializing a statically or globally > declared object; C will guarantee zero-initialization for us. And several > of the functions explicitly called memset anyway. > > Besides, this way grepping for .to_require_attach\ = will only find targets > which define it to something useful. > > I'll commit this tomorrow unless someone sees a problem with it. > > Note1: remote-st.c hasn't been compilable in a while; m68*-tandem-* is > probably a good candidate for the hitlist. From a glance it looks like it > has been broken since the HP merge added the NULL assignments I'm removing, > which is about three years now I think. > > Note2: The DONT_USE member of struct target_ops can go now. The fact that 13 files were doing it should suggest that it was intentional. Might want to wait a bit longer while someone dregs up the history. Andrew