From: Andrew Cagney <ac131313@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: Elena Zannoni <ezannoni@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFA] Move _initialize_hppa_tdep to the end of file
Date: Wed, 06 Nov 2002 18:39:00 -0000 [thread overview]
Message-ID: <3DC9D25B.8070601@redhat.com> (raw)
In-Reply-To: <20021107023312.GK5164@gnat.com>
> > 2002-11-05 Joel Brobecker <brobecker@gnat.com>
>> >
>> > * hppa-tdep.c (_initialize_hppa_tdep): Move function body
>> > to end of file, to be more consistent with the pratice followed
>> > in other targets.
>>
>> Sure.
>
>
> Thanks for the little confirmation that this change was ok.
>
>
>> Actually multiarching a target is considered an obvious activity, so
>> you have the option of just post patches, instead of RFA's. For
>> instance see the multiarching of the h8300 (please do it with
>> incremental patches).
>
>
> The trouble is that I still consider myself new to the GDB project,
> and look forward to the many years of learning to come with great
> spirit. In the meantime, I often feel more confortable after I asked
> for a quick confirmation that my understanding was correct before
> doing some checkins that seem too obvious to be correct.
>
> The testsuite is a good tool, but is sometimes not enough. I could for
> instance introduce a bug in a different target.
It's an accepted risk. Multi-arching takes priority over keeping things
working 100%. Besides, if you're modifying HP files, the only thing you
can break is HP stuff :-)
> But I do reassure you, I will try to do as much as possible of the
> multiarch conversion without asking for RFAs :-).
One suggestion. If you hit a problem (eg a method isn't yet multi-arch)
put it to one side and work on something else.
Good luck!
Andrew
prev parent reply other threads:[~2002-11-07 2:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-05 18:23 Joel Brobecker
2002-11-05 19:23 ` Daniel Jacobowitz
2002-11-06 18:35 ` Joel Brobecker
2002-11-13 19:26 ` Andrew Cagney
2002-11-05 19:45 ` Elena Zannoni
2002-11-06 18:30 ` Joel Brobecker
2002-11-06 18:39 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DC9D25B.8070601@redhat.com \
--to=ac131313@redhat.com \
--cc=brobecker@gnat.com \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox