From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25497 invoked by alias); 7 Nov 2002 02:39:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25414 invoked from network); 7 Nov 2002 02:39:22 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 7 Nov 2002 02:39:22 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3AE383CD3; Wed, 6 Nov 2002 21:39:23 -0500 (EST) Message-ID: <3DC9D25B.8070601@redhat.com> Date: Wed, 06 Nov 2002 18:39:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFA] Move _initialize_hppa_tdep to the end of file References: <20021106022555.GN5164@gnat.com> <15816.36335.124501.342414@localhost.redhat.com> <20021107023312.GK5164@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-11/txt/msg00167.txt.bz2 > > 2002-11-05 Joel Brobecker >> > >> > * hppa-tdep.c (_initialize_hppa_tdep): Move function body >> > to end of file, to be more consistent with the pratice followed >> > in other targets. >> >> Sure. > > > Thanks for the little confirmation that this change was ok. > > >> Actually multiarching a target is considered an obvious activity, so >> you have the option of just post patches, instead of RFA's. For >> instance see the multiarching of the h8300 (please do it with >> incremental patches). > > > The trouble is that I still consider myself new to the GDB project, > and look forward to the many years of learning to come with great > spirit. In the meantime, I often feel more confortable after I asked > for a quick confirmation that my understanding was correct before > doing some checkins that seem too obvious to be correct. > > The testsuite is a good tool, but is sometimes not enough. I could for > instance introduce a bug in a different target. It's an accepted risk. Multi-arching takes priority over keeping things working 100%. Besides, if you're modifying HP files, the only thing you can break is HP stuff :-) > But I do reassure you, I will try to do as much as possible of the > multiarch conversion without asking for RFAs :-). One suggestion. If you hit a problem (eg a method isn't yet multi-arch) put it to one side and work on something else. Good luck! Andrew