Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [PATCH/RFA] Move _initialize_hppa_tdep to the end of file
Date: Tue, 05 Nov 2002 18:23:00 -0000	[thread overview]
Message-ID: <20021106022555.GN5164@gnat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

I'd like more _initialize_hppa_tdep to the end of the file. This is not
absolutely needed, but it conforms a bit better with the practice I've
seen used for other targets. If nobody objects, I'd like to check this
in tomorrow.

A patch to add the gdbarch framework will shortly follow the checkin.

2002-11-05  Joel Brobecker  <brobecker@gnat.com>

        * hppa-tdep.c (_initialize_hppa_tdep): Move function body
        to end of file, to be more consistent with the pratice followed
        in other targets.

-- 
Joel

[-- Attachment #2: hppa-tdep.c.diff --]
[-- Type: text/plain, Size: 4752 bytes --]

Index: hppa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/hppa-tdep.c,v
retrieving revision 1.29
diff -c -3 -p -r1.29 hppa-tdep.c
*** hppa-tdep.c	30 Oct 2002 20:42:54 -0000	1.29
--- hppa-tdep.c	6 Nov 2002 02:18:50 -0000
*************** hppa_skip_permanent_breakpoint (void)
*** 4674,4724 ****
    /* We can leave the tail's space the same, since there's no jump.  */
  }
  
- void
- _initialize_hppa_tdep (void)
- {
-   struct cmd_list_element *c;
-   void break_at_finish_command (char *arg, int from_tty);
-   void tbreak_at_finish_command (char *arg, int from_tty);
-   void break_at_finish_at_depth_command (char *arg, int from_tty);
- 
-   tm_print_insn = print_insn_hppa;
- 
-   add_cmd ("unwind", class_maintenance, unwind_command,
- 	   "Print unwind table entry at given address.",
- 	   &maintenanceprintlist);
- 
-   deprecate_cmd (add_com ("xbreak", class_breakpoint, 
- 			  break_at_finish_command,
- 			  concat ("Set breakpoint at procedure exit. \n\
- Argument may be function name, or \"*\" and an address.\n\
- If function is specified, break at end of code for that function.\n\
- If an address is specified, break at the end of the function that contains \n\
- that exact address.\n",
- 		   "With no arg, uses current execution address of selected stack frame.\n\
- This is useful for breaking on return to a stack frame.\n\
- \n\
- Multiple breakpoints at one place are permitted, and useful if conditional.\n\
- \n\
- Do \"help breakpoints\" for info on other commands dealing with breakpoints.", NULL)), NULL);
-   deprecate_cmd (add_com_alias ("xb", "xbreak", class_breakpoint, 1), NULL);
-   deprecate_cmd (add_com_alias ("xbr", "xbreak", class_breakpoint, 1), NULL);
-   deprecate_cmd (add_com_alias ("xbre", "xbreak", class_breakpoint, 1), NULL);
-   deprecate_cmd (add_com_alias ("xbrea", "xbreak", class_breakpoint, 1), NULL);
- 
-   deprecate_cmd (c = add_com ("txbreak", class_breakpoint, 
- 			      tbreak_at_finish_command,
- "Set temporary breakpoint at procedure exit.  Either there should\n\
- be no argument or the argument must be a depth.\n"), NULL);
-   set_cmd_completer (c, location_completer);
-   
-   if (xdb_commands)
-     deprecate_cmd (add_com ("bx", class_breakpoint, 
- 			    break_at_finish_at_depth_command,
- "Set breakpoint at procedure exit.  Either there should\n\
- be no argument or the argument must be a depth.\n"), NULL);
- }
- 
  /* Copy the function value from VALBUF into the proper location
     for a function return.
  
--- 4674,4679 ----
*************** hppa_extract_return_value (struct type *
*** 4768,4770 ****
--- 4723,4771 ----
  		: (4 - TYPE_LENGTH (type)))),
  	    TYPE_LENGTH (type));
  }
+ 
+ void
+ _initialize_hppa_tdep (void)
+ {
+   struct cmd_list_element *c;
+   void break_at_finish_command (char *arg, int from_tty);
+   void tbreak_at_finish_command (char *arg, int from_tty);
+   void break_at_finish_at_depth_command (char *arg, int from_tty);
+ 
+   tm_print_insn = print_insn_hppa;
+ 
+   add_cmd ("unwind", class_maintenance, unwind_command,
+ 	   "Print unwind table entry at given address.",
+ 	   &maintenanceprintlist);
+ 
+   deprecate_cmd (add_com ("xbreak", class_breakpoint, 
+ 			  break_at_finish_command,
+ 			  concat ("Set breakpoint at procedure exit. \n\
+ Argument may be function name, or \"*\" and an address.\n\
+ If function is specified, break at end of code for that function.\n\
+ If an address is specified, break at the end of the function that contains \n\
+ that exact address.\n",
+ 		   "With no arg, uses current execution address of selected stack frame.\n\
+ This is useful for breaking on return to a stack frame.\n\
+ \n\
+ Multiple breakpoints at one place are permitted, and useful if conditional.\n\
+ \n\
+ Do \"help breakpoints\" for info on other commands dealing with breakpoints.", NULL)), NULL);
+   deprecate_cmd (add_com_alias ("xb", "xbreak", class_breakpoint, 1), NULL);
+   deprecate_cmd (add_com_alias ("xbr", "xbreak", class_breakpoint, 1), NULL);
+   deprecate_cmd (add_com_alias ("xbre", "xbreak", class_breakpoint, 1), NULL);
+   deprecate_cmd (add_com_alias ("xbrea", "xbreak", class_breakpoint, 1), NULL);
+ 
+   deprecate_cmd (c = add_com ("txbreak", class_breakpoint, 
+ 			      tbreak_at_finish_command,
+ "Set temporary breakpoint at procedure exit.  Either there should\n\
+ be no argument or the argument must be a depth.\n"), NULL);
+   set_cmd_completer (c, location_completer);
+   
+   if (xdb_commands)
+     deprecate_cmd (add_com ("bx", class_breakpoint, 
+ 			    break_at_finish_at_depth_command,
+ "Set breakpoint at procedure exit.  Either there should\n\
+ be no argument or the argument must be a depth.\n"), NULL);
+ }
+ 

             reply	other threads:[~2002-11-06  2:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-05 18:23 Joel Brobecker [this message]
2002-11-05 19:23 ` Daniel Jacobowitz
2002-11-06 18:35   ` Joel Brobecker
2002-11-13 19:26     ` Andrew Cagney
2002-11-05 19:45 ` Elena Zannoni
2002-11-06 18:30   ` Joel Brobecker
2002-11-06 18:39     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021106022555.GN5164@gnat.com \
    --to=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox