From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30011 invoked by alias); 6 Nov 2002 02:23:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29866 invoked from network); 6 Nov 2002 02:23:17 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 6 Nov 2002 02:23:17 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 3552CD2CC8; Tue, 5 Nov 2002 18:25:55 -0800 (PST) Date: Tue, 05 Nov 2002 18:23:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: [PATCH/RFA] Move _initialize_hppa_tdep to the end of file Message-ID: <20021106022555.GN5164@gnat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="DqhR8hV3EnoxUkKN" Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2002-11/txt/msg00086.txt.bz2 --DqhR8hV3EnoxUkKN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 523 I'd like more _initialize_hppa_tdep to the end of the file. This is not absolutely needed, but it conforms a bit better with the practice I've seen used for other targets. If nobody objects, I'd like to check this in tomorrow. A patch to add the gdbarch framework will shortly follow the checkin. 2002-11-05 Joel Brobecker * hppa-tdep.c (_initialize_hppa_tdep): Move function body to end of file, to be more consistent with the pratice followed in other targets. -- Joel --DqhR8hV3EnoxUkKN Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="hppa-tdep.c.diff" Content-length: 4752 Index: hppa-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/hppa-tdep.c,v retrieving revision 1.29 diff -c -3 -p -r1.29 hppa-tdep.c *** hppa-tdep.c 30 Oct 2002 20:42:54 -0000 1.29 --- hppa-tdep.c 6 Nov 2002 02:18:50 -0000 *************** hppa_skip_permanent_breakpoint (void) *** 4674,4724 **** /* We can leave the tail's space the same, since there's no jump. */ } - void - _initialize_hppa_tdep (void) - { - struct cmd_list_element *c; - void break_at_finish_command (char *arg, int from_tty); - void tbreak_at_finish_command (char *arg, int from_tty); - void break_at_finish_at_depth_command (char *arg, int from_tty); - - tm_print_insn = print_insn_hppa; - - add_cmd ("unwind", class_maintenance, unwind_command, - "Print unwind table entry at given address.", - &maintenanceprintlist); - - deprecate_cmd (add_com ("xbreak", class_breakpoint, - break_at_finish_command, - concat ("Set breakpoint at procedure exit. \n\ - Argument may be function name, or \"*\" and an address.\n\ - If function is specified, break at end of code for that function.\n\ - If an address is specified, break at the end of the function that contains \n\ - that exact address.\n", - "With no arg, uses current execution address of selected stack frame.\n\ - This is useful for breaking on return to a stack frame.\n\ - \n\ - Multiple breakpoints at one place are permitted, and useful if conditional.\n\ - \n\ - Do \"help breakpoints\" for info on other commands dealing with breakpoints.", NULL)), NULL); - deprecate_cmd (add_com_alias ("xb", "xbreak", class_breakpoint, 1), NULL); - deprecate_cmd (add_com_alias ("xbr", "xbreak", class_breakpoint, 1), NULL); - deprecate_cmd (add_com_alias ("xbre", "xbreak", class_breakpoint, 1), NULL); - deprecate_cmd (add_com_alias ("xbrea", "xbreak", class_breakpoint, 1), NULL); - - deprecate_cmd (c = add_com ("txbreak", class_breakpoint, - tbreak_at_finish_command, - "Set temporary breakpoint at procedure exit. Either there should\n\ - be no argument or the argument must be a depth.\n"), NULL); - set_cmd_completer (c, location_completer); - - if (xdb_commands) - deprecate_cmd (add_com ("bx", class_breakpoint, - break_at_finish_at_depth_command, - "Set breakpoint at procedure exit. Either there should\n\ - be no argument or the argument must be a depth.\n"), NULL); - } - /* Copy the function value from VALBUF into the proper location for a function return. --- 4674,4679 ---- *************** hppa_extract_return_value (struct type * *** 4768,4770 **** --- 4723,4771 ---- : (4 - TYPE_LENGTH (type)))), TYPE_LENGTH (type)); } + + void + _initialize_hppa_tdep (void) + { + struct cmd_list_element *c; + void break_at_finish_command (char *arg, int from_tty); + void tbreak_at_finish_command (char *arg, int from_tty); + void break_at_finish_at_depth_command (char *arg, int from_tty); + + tm_print_insn = print_insn_hppa; + + add_cmd ("unwind", class_maintenance, unwind_command, + "Print unwind table entry at given address.", + &maintenanceprintlist); + + deprecate_cmd (add_com ("xbreak", class_breakpoint, + break_at_finish_command, + concat ("Set breakpoint at procedure exit. \n\ + Argument may be function name, or \"*\" and an address.\n\ + If function is specified, break at end of code for that function.\n\ + If an address is specified, break at the end of the function that contains \n\ + that exact address.\n", + "With no arg, uses current execution address of selected stack frame.\n\ + This is useful for breaking on return to a stack frame.\n\ + \n\ + Multiple breakpoints at one place are permitted, and useful if conditional.\n\ + \n\ + Do \"help breakpoints\" for info on other commands dealing with breakpoints.", NULL)), NULL); + deprecate_cmd (add_com_alias ("xb", "xbreak", class_breakpoint, 1), NULL); + deprecate_cmd (add_com_alias ("xbr", "xbreak", class_breakpoint, 1), NULL); + deprecate_cmd (add_com_alias ("xbre", "xbreak", class_breakpoint, 1), NULL); + deprecate_cmd (add_com_alias ("xbrea", "xbreak", class_breakpoint, 1), NULL); + + deprecate_cmd (c = add_com ("txbreak", class_breakpoint, + tbreak_at_finish_command, + "Set temporary breakpoint at procedure exit. Either there should\n\ + be no argument or the argument must be a depth.\n"), NULL); + set_cmd_completer (c, location_completer); + + if (xdb_commands) + deprecate_cmd (add_com ("bx", class_breakpoint, + break_at_finish_at_depth_command, + "Set breakpoint at procedure exit. Either there should\n\ + be no argument or the argument must be a depth.\n"), NULL); + } + --DqhR8hV3EnoxUkKN--