Re: RFC: CLI clenup and edit command

[Fernando Nasser <fnasser@redhat.com>]

Andrew, your comments are valid and I will be working on a patch to 
implement your suggestion (get rid of get_current_or_default...()) and 
fill in the two unused sal fields (I don't know why I didn't do it, I 
did intend to).

But...

Andrew Cagney wrote:
> Fernando,
> 
> This patch broke nodebug.exp.  

Here are the resuls before my test:

Running 
/home/fnasser/DEVO/insight-sourceware/src/gdb/testsuite/gdb.base/nodebug.exp 
...
PASS: gdb.base/nodebug.exp: p top
PASS: gdb.base/nodebug.exp: whatis top
PASS: gdb.base/nodebug.exp: ptype top
PASS: gdb.base/nodebug.exp: p middle
PASS: gdb.base/nodebug.exp: whatis middle
PASS: gdb.base/nodebug.exp: ptype middle
PASS: gdb.base/nodebug.exp: p dataglobal
PASS: gdb.base/nodebug.exp: whatis dataglobal
PASS: gdb.base/nodebug.exp: ptype dataglobal
PASS: gdb.base/nodebug.exp: p datalocal
PASS: gdb.base/nodebug.exp: whatis datalocal
PASS: gdb.base/nodebug.exp: ptype datalocal
PASS: gdb.base/nodebug.exp: p bssglobal
PASS: gdb.base/nodebug.exp: whatis bssglobal
PASS: gdb.base/nodebug.exp: ptype bssglobal
PASS: gdb.base/nodebug.exp: p bsslocal
PASS: gdb.base/nodebug.exp: whatis bsslocal
PASS: gdb.base/nodebug.exp: ptype bsslocal
PASS: gdb.base/nodebug.exp: backtrace from inner in nodebug.exp
PASS: gdb.base/nodebug.exp: p/c array_index("abcdef",2)
PASS: gdb.base/nodebug.exp: backtrace from middle in nodebug.exp

And here are the results after my patch:

Running 
/home/fnasser/DEVO/insight-sourceware/src/gdb/testsuite/gdb.base/nodebug.exp 
...
PASS: gdb.base/nodebug.exp: p top
PASS: gdb.base/nodebug.exp: whatis top
PASS: gdb.base/nodebug.exp: ptype top
PASS: gdb.base/nodebug.exp: p middle
PASS: gdb.base/nodebug.exp: whatis middle
PASS: gdb.base/nodebug.exp: ptype middle
PASS: gdb.base/nodebug.exp: p dataglobal
PASS: gdb.base/nodebug.exp: whatis dataglobal
PASS: gdb.base/nodebug.exp: ptype dataglobal
PASS: gdb.base/nodebug.exp: p datalocal
PASS: gdb.base/nodebug.exp: whatis datalocal
PASS: gdb.base/nodebug.exp: ptype datalocal
PASS: gdb.base/nodebug.exp: p bssglobal
PASS: gdb.base/nodebug.exp: whatis bssglobal
PASS: gdb.base/nodebug.exp: ptype bssglobal
PASS: gdb.base/nodebug.exp: p bsslocal
PASS: gdb.base/nodebug.exp: whatis bsslocal
PASS: gdb.base/nodebug.exp: ptype bsslocal
PASS: gdb.base/nodebug.exp: backtrace from inner in nodebug.exp
PASS: gdb.base/nodebug.exp: p/c array_index("abcdef",2)
PASS: gdb.base/nodebug.exp: backtrace from middle in nodebug.exp


I don't see the regression.  You know I always run the regression tests 
before and after any patch.  It is true I only run it on Linux as this 
is the only system I have at the moment...


Interesting enough, the change to breakpoint.c is indeed wrong.  I 
probably cut-and-pasted and forgot to delete the "or_default".
Thanks for spotting it.


Regards,
Fernando



-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9