From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18869 invoked by alias); 22 Sep 2002 20:14:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18861 invoked from network); 22 Sep 2002 20:14:34 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 22 Sep 2002 20:14:34 -0000 Received: from redhat.com (tooth.toronto.redhat.com [172.16.14.29]) by touchme.toronto.redhat.com (Postfix) with ESMTP id F137480022C; Sun, 22 Sep 2002 16:14:33 -0400 (EDT) Message-ID: <3D8E2454.4010804@redhat.com> Date: Sun, 22 Sep 2002 13:14:00 -0000 From: Fernando Nasser Organization: Red Hat Canada User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020607 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: RFC: CLI clenup and edit command References: <3D82489E.3080203@redhat.com> <3D8D2C16.50005@ges.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-09/txt/msg00554.txt.bz2 Andrew, your comments are valid and I will be working on a patch to implement your suggestion (get rid of get_current_or_default...()) and fill in the two unused sal fields (I don't know why I didn't do it, I did intend to). But... Andrew Cagney wrote: > Fernando, > > This patch broke nodebug.exp. Here are the resuls before my test: Running /home/fnasser/DEVO/insight-sourceware/src/gdb/testsuite/gdb.base/nodebug.exp ... PASS: gdb.base/nodebug.exp: p top PASS: gdb.base/nodebug.exp: whatis top PASS: gdb.base/nodebug.exp: ptype top PASS: gdb.base/nodebug.exp: p middle PASS: gdb.base/nodebug.exp: whatis middle PASS: gdb.base/nodebug.exp: ptype middle PASS: gdb.base/nodebug.exp: p dataglobal PASS: gdb.base/nodebug.exp: whatis dataglobal PASS: gdb.base/nodebug.exp: ptype dataglobal PASS: gdb.base/nodebug.exp: p datalocal PASS: gdb.base/nodebug.exp: whatis datalocal PASS: gdb.base/nodebug.exp: ptype datalocal PASS: gdb.base/nodebug.exp: p bssglobal PASS: gdb.base/nodebug.exp: whatis bssglobal PASS: gdb.base/nodebug.exp: ptype bssglobal PASS: gdb.base/nodebug.exp: p bsslocal PASS: gdb.base/nodebug.exp: whatis bsslocal PASS: gdb.base/nodebug.exp: ptype bsslocal PASS: gdb.base/nodebug.exp: backtrace from inner in nodebug.exp PASS: gdb.base/nodebug.exp: p/c array_index("abcdef",2) PASS: gdb.base/nodebug.exp: backtrace from middle in nodebug.exp And here are the results after my patch: Running /home/fnasser/DEVO/insight-sourceware/src/gdb/testsuite/gdb.base/nodebug.exp ... PASS: gdb.base/nodebug.exp: p top PASS: gdb.base/nodebug.exp: whatis top PASS: gdb.base/nodebug.exp: ptype top PASS: gdb.base/nodebug.exp: p middle PASS: gdb.base/nodebug.exp: whatis middle PASS: gdb.base/nodebug.exp: ptype middle PASS: gdb.base/nodebug.exp: p dataglobal PASS: gdb.base/nodebug.exp: whatis dataglobal PASS: gdb.base/nodebug.exp: ptype dataglobal PASS: gdb.base/nodebug.exp: p datalocal PASS: gdb.base/nodebug.exp: whatis datalocal PASS: gdb.base/nodebug.exp: ptype datalocal PASS: gdb.base/nodebug.exp: p bssglobal PASS: gdb.base/nodebug.exp: whatis bssglobal PASS: gdb.base/nodebug.exp: ptype bssglobal PASS: gdb.base/nodebug.exp: p bsslocal PASS: gdb.base/nodebug.exp: whatis bsslocal PASS: gdb.base/nodebug.exp: ptype bsslocal PASS: gdb.base/nodebug.exp: backtrace from inner in nodebug.exp PASS: gdb.base/nodebug.exp: p/c array_index("abcdef",2) PASS: gdb.base/nodebug.exp: backtrace from middle in nodebug.exp I don't see the regression. You know I always run the regression tests before and after any patch. It is true I only run it on Linux as this is the only system I have at the moment... Interesting enough, the change to breakpoint.c is indeed wrong. I probably cut-and-pasted and forgot to delete the "or_default". Thanks for spotting it. Regards, Fernando -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9