Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@ges.redhat.com>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Don't include vector registers in ``info registers''
Date: Tue, 13 Aug 2002 14:45:00 -0000	[thread overview]
Message-ID: <3D597E08.5040300@ges.redhat.com> (raw)
In-Reply-To: <15699.9081.661920.38447@localhost.redhat.com>

> Ah, compare with what the rs6000-tdep.c has:
> rs6000_do_registers_info().
> 
> I made the same change, but also added a skipping of the print of a
> single vector register in decimal, it was taking up too much screen
> real estate.
> 
>           /* If not a vector register, print it also in decimal.  */
> 	  if (!altivec_register_p (i))
> 	    {
> 	      printf_filtered ("\t");
> 	      val_print (REGISTER_VIRTUAL_TYPE (i), virtual_buffer, 0, 0,
> 			 gdb_stdout, 0, 1, 0, Val_pretty_default);
> 	    }

Hmm, yes, the vector register output is a bit long.

> I also did something different: defining altivec_register_p(). I was
> envisioning this predicate becoming an architecture method called
> vector_register_p().

Yes, I know GUI people are crying out for some sort of register 
attribute mechanism.  If/when it is added the current tests could 
quickly be replaced with more generic code that, by default, used the 
current heuristics.

> Another thing I've done in rs6000-tdep.c is the 'info vector' command
> (even though it is called 'info altivec').
> 
> I'll be submitting shortly another powerpc variation (the e500) which
> has vector registers, so I generalized things a bit in that file, wrt
> vector registers.

Hmm...

Andrew



  parent reply	other threads:[~2002-08-13 21:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-08 16:52 Andrew Cagney
2002-08-08 17:07 ` Andrew Cagney
2002-08-08 19:07   ` Elena Zannoni
2002-08-08 19:24     ` Andrew Cagney
2002-08-13 14:45     ` Andrew Cagney [this message]
2002-08-09 11:39   ` Andrew Cagney
2002-08-15 17:12   ` Andrew Cagney
2002-08-08 18:33 ` Daniel Jacobowitz
2002-08-08 18:45   ` Michael Snyder
2002-08-08 19:35   ` Andrew Cagney
2002-08-08 18:50 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D597E08.5040300@ges.redhat.com \
    --to=ac131313@ges.redhat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox