From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15758 invoked by alias); 13 Aug 2002 21:45:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15748 invoked from network); 13 Aug 2002 21:45:46 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 13 Aug 2002 21:45:46 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 39FA33D39; Tue, 13 Aug 2002 17:45:44 -0400 (EDT) Message-ID: <3D597E08.5040300@ges.redhat.com> Date: Tue, 13 Aug 2002 14:45:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020810 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Elena Zannoni Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Don't include vector registers in ``info registers'' References: <3D53041D.90609@ges.redhat.com> <3D5307C9.2010003@ges.redhat.com> <15699.9081.661920.38447@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00321.txt.bz2 > Ah, compare with what the rs6000-tdep.c has: > rs6000_do_registers_info(). > > I made the same change, but also added a skipping of the print of a > single vector register in decimal, it was taking up too much screen > real estate. > > /* If not a vector register, print it also in decimal. */ > if (!altivec_register_p (i)) > { > printf_filtered ("\t"); > val_print (REGISTER_VIRTUAL_TYPE (i), virtual_buffer, 0, 0, > gdb_stdout, 0, 1, 0, Val_pretty_default); > } Hmm, yes, the vector register output is a bit long. > I also did something different: defining altivec_register_p(). I was > envisioning this predicate becoming an architecture method called > vector_register_p(). Yes, I know GUI people are crying out for some sort of register attribute mechanism. If/when it is added the current tests could quickly be replaced with more generic code that, by default, used the current heuristics. > Another thing I've done in rs6000-tdep.c is the 'info vector' command > (even though it is called 'info altivec'). > > I'll be submitting shortly another powerpc variation (the e500) which > has vector registers, so I generalized things a bit in that file, wrt > vector registers. Hmm... Andrew