From: Andrew Cagney <ac131313@ges.redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Missing #include in objfiles.h?
Date: Sat, 03 Aug 2002 16:25:00 -0000 [thread overview]
Message-ID: <3D4C6657.6070803@ges.redhat.com> (raw)
In-Reply-To: <20020803031009.GE3259@gnat.com>
> On Thu, Aug 01, 2002 at 04:48:05PM -0400, Andrew Cagney wrote:
>
>> >I'm not sure if this is intended or not, but objfiles.h relies on
>> >symfile.h for the definition of certain structures. However, objfiles
>> >does not #include symfile. So my attempt to include objfiles without
>> >prior including symfile caused a compilation error.
>
>>
>> What exactly? A mindless grep suggests opaque references but not a hard
>> dependency. Adding an opaque ``struct sym_fns;'' to avoid an include is ok.
>
>
> Here are the fields in struct objfile that cause the compilation error:
>
> /* Vectors of all partial symbols read in from file. The actual data
> is stored in the psymbol_obstack. */
>
> struct psymbol_allocation_list global_psymbols;
> struct psymbol_allocation_list static_psymbols;
>
> So the full definition is need for this file to compile.
Ah! In that case, yes definitly.
Andrew
next prev parent reply other threads:[~2002-08-03 23:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-01 12:28 Joel Brobecker
2002-08-01 13:48 ` Andrew Cagney
2002-08-02 20:10 ` Joel Brobecker
2002-08-03 16:25 ` Andrew Cagney [this message]
2002-08-05 9:18 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D4C6657.6070803@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox