From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1722 invoked by alias); 3 Aug 2002 23:25:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1712 invoked from network); 3 Aug 2002 23:25:18 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 3 Aug 2002 23:25:18 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 686353D60; Sat, 3 Aug 2002 19:25:11 -0400 (EDT) Message-ID: <3D4C6657.6070803@ges.redhat.com> Date: Sat, 03 Aug 2002 16:25:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020802 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Missing #include in objfiles.h? References: <20020801192836.GY683@gnat.com> <3D499E85.9080506@ges.redhat.com> <20020803031009.GE3259@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00071.txt.bz2 > On Thu, Aug 01, 2002 at 04:48:05PM -0400, Andrew Cagney wrote: > >> >I'm not sure if this is intended or not, but objfiles.h relies on >> >symfile.h for the definition of certain structures. However, objfiles >> >does not #include symfile. So my attempt to include objfiles without >> >prior including symfile caused a compilation error. > >> >> What exactly? A mindless grep suggests opaque references but not a hard >> dependency. Adding an opaque ``struct sym_fns;'' to avoid an include is ok. > > > Here are the fields in struct objfile that cause the compilation error: > > /* Vectors of all partial symbols read in from file. The actual data > is stored in the psymbol_obstack. */ > > struct psymbol_allocation_list global_psymbols; > struct psymbol_allocation_list static_psymbols; > > So the full definition is need for this file to compile. Ah! In that case, yes definitly. Andrew