From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] Missing #include in objfiles.h?
Date: Thu, 01 Aug 2002 12:28:00 -0000 [thread overview]
Message-ID: <20020801192836.GY683@gnat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
I'm not sure if this is intended or not, but objfiles.h relies on
symfile.h for the definition of certain structures. However, objfiles
does not #include symfile. So my attempt to include objfiles without
prior including symfile caused a compilation error.
This patch adds the #include, assuming this was not intentional. Tested
by "./configure; make".
2002-08-01 Joel Brobecker <brobecker@gnat.com>
* objfiles.h: Add missing #include "symfile.h"
* Makefile.in (objfiles_h): Add dependency on symfile.h and dependents.
Ok to apply?
Thanks,
--
Joel
[-- Attachment #2: objfiles.h.diff --]
[-- Type: text/plain, Size: 1405 bytes --]
Index: objfiles.h
===================================================================
RCS file: /cvs/src/src/gdb/objfiles.h,v
retrieving revision 1.14
diff -c -3 -p -r1.14 objfiles.h
*** objfiles.h 29 Jul 2002 22:55:26 -0000 1.14
--- objfiles.h 1 Aug 2002 19:21:33 -0000
***************
*** 24,29 ****
--- 24,31 ----
#define OBJFILES_H
#include "gdb_obstack.h" /* For obstack internals. */
+ #include "symfile.h"
+
struct bcache;
/* This structure maintains information on a per-objfile basis about the
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.228
diff -c -3 -p -r1.228 Makefile.in
*** Makefile.in 30 Jul 2002 19:59:06 -0000 1.228
--- Makefile.in 1 Aug 2002 19:21:35 -0000
*************** macrotab_h = macrotab.h
*** 656,662 ****
macroscope_h = macroscope.h $(macrotab_h) $(symtab_h)
memattr_h = memattr.h
monitor_h = monitor.h
! objfiles_h = objfiles.h $(gdb_obstack_h)
parser_defs_h = parser-defs.h $(doublest_h)
ppc_tdep_h = ppc-tdep.h osabi.h
regcache_h = regcache.h
--- 656,662 ----
macroscope_h = macroscope.h $(macrotab_h) $(symtab_h)
memattr_h = memattr.h
monitor_h = monitor.h
! objfiles_h = objfiles.h $(gdb_obstack_h) $(symfile_h)
parser_defs_h = parser-defs.h $(doublest_h)
ppc_tdep_h = ppc-tdep.h osabi.h
regcache_h = regcache.h
next reply other threads:[~2002-08-01 19:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-01 12:28 Joel Brobecker [this message]
2002-08-01 13:48 ` Andrew Cagney
2002-08-02 20:10 ` Joel Brobecker
2002-08-03 16:25 ` Andrew Cagney
2002-08-05 9:18 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020801192836.GY683@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox