From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31420 invoked by alias); 1 Aug 2002 19:28:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31407 invoked from network); 1 Aug 2002 19:28:37 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 1 Aug 2002 19:28:37 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 11D20D2CBD; Thu, 1 Aug 2002 12:28:37 -0700 (PDT) Date: Thu, 01 Aug 2002 12:28:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: [RFA] Missing #include in objfiles.h? Message-ID: <20020801192836.GY683@gnat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="C+ts3FVlLX8+P6JN" Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2002-08/txt/msg00014.txt.bz2 --C+ts3FVlLX8+P6JN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 582 I'm not sure if this is intended or not, but objfiles.h relies on symfile.h for the definition of certain structures. However, objfiles does not #include symfile. So my attempt to include objfiles without prior including symfile caused a compilation error. This patch adds the #include, assuming this was not intentional. Tested by "./configure; make". 2002-08-01 Joel Brobecker * objfiles.h: Add missing #include "symfile.h" * Makefile.in (objfiles_h): Add dependency on symfile.h and dependents. Ok to apply? Thanks, -- Joel --C+ts3FVlLX8+P6JN Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="objfiles.h.diff" Content-length: 1405 Index: objfiles.h =================================================================== RCS file: /cvs/src/src/gdb/objfiles.h,v retrieving revision 1.14 diff -c -3 -p -r1.14 objfiles.h *** objfiles.h 29 Jul 2002 22:55:26 -0000 1.14 --- objfiles.h 1 Aug 2002 19:21:33 -0000 *************** *** 24,29 **** --- 24,31 ---- #define OBJFILES_H #include "gdb_obstack.h" /* For obstack internals. */ + #include "symfile.h" + struct bcache; /* This structure maintains information on a per-objfile basis about the Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.228 diff -c -3 -p -r1.228 Makefile.in *** Makefile.in 30 Jul 2002 19:59:06 -0000 1.228 --- Makefile.in 1 Aug 2002 19:21:35 -0000 *************** macrotab_h = macrotab.h *** 656,662 **** macroscope_h = macroscope.h $(macrotab_h) $(symtab_h) memattr_h = memattr.h monitor_h = monitor.h ! objfiles_h = objfiles.h $(gdb_obstack_h) parser_defs_h = parser-defs.h $(doublest_h) ppc_tdep_h = ppc-tdep.h osabi.h regcache_h = regcache.h --- 656,662 ---- macroscope_h = macroscope.h $(macrotab_h) $(symtab_h) memattr_h = memattr.h monitor_h = monitor.h ! objfiles_h = objfiles.h $(gdb_obstack_h) $(symfile_h) parser_defs_h = parser-defs.h $(doublest_h) ppc_tdep_h = ppc-tdep.h osabi.h regcache_h = regcache.h --C+ts3FVlLX8+P6JN--