Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@ges.redhat.com>
To: Michael Snyder <msnyder@redhat.com>, Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] 64-bit support for Irix 6
Date: Thu, 01 Aug 2002 14:25:00 -0000	[thread overview]
Message-ID: <3D49A72F.7040108@ges.redhat.com> (raw)
In-Reply-To: <3D499BCF.2E79188@redhat.com>

> Andrew Cagney wrote:
> 
>> 
> 
>> >
>> >  #include "mips/tm-bigmips.h"
>> >
>> > +#undef MIPS_REGSIZE
>> > +#define MIPS_REGSIZE 8
>> > +
>> >  /* SGI's assembler doesn't grok dollar signs in identifiers.
>> >     So we use dots instead.  This item must be coordinated with G++. */
>> >  #undef CPLUS_MARKER
>> > @@ -89,11 +92,12 @@
>> >        32 * sizeof(double) + ((N) - 32) * MIPS_REGSIZE)
>> >
>> >  #undef  REGISTER_VIRTUAL_TYPE
>> > +/* define 8 byte register type */
>> >  #define REGISTER_VIRTUAL_TYPE(N) \
>> >       (((N) >= FP0_REGNUM && (N) < FP0_REGNUM+32) ? builtin_type_double \
>> >        : ((N) == 32 /*SR*/) ? builtin_type_uint32 \
>> >        : ((N) >= 70 && (N) <= 89) ? builtin_type_uint32 \
>> > -      : builtin_type_int)
>> > +      : builtin_type_long_long)
>> >
>> >  /* Force N32 ABI as the default. */
>> >  #define MIPS_DEFAULT_ABI MIPS_ABI_N32
>> >
> 
>> 
>> Kevin, this is wrong.
>> 
>> It is no longer acceptable to add support for an additional sub-target
>> using non-multi-arch mechanisms.
> 
> 
> Does that mean that if we touch a macro, we have to multi-arch it?

If you want to fix a bug in a macro then you should first (separatly) 
convert it to a macro/function pair.  I believe this is accepted as 
``current best pratice''.

If you want to change a bunch of macros to support an additional 
architecture variant then they need to be multi-arch.  GDB no longer 
accepts an architecture variants that isn't multi-arch.

> For instance, if we touch the PUSH_ARGUMENTS function, and
> PUSH_ARGUMENTS 
> hasn't been multi-arched, do we have to multi-arch it?

If you mean mips_push_arguments, then that is already part of the 
multi-arch vector.  Just don't forget that any changes to that function 
should be multi-arch friendly.

enjoy,
Andrew



  reply	other threads:[~2002-08-01 21:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-31 11:23 Kevin Buettner
2002-08-01  8:11 ` Andrew Cagney
2002-08-01  9:53   ` Kevin Buettner
2002-08-01 10:42     ` Andrew Cagney
2002-08-01 13:08       ` Kevin Buettner
2002-08-01 13:28         ` Andrew Cagney
2002-08-01 16:17           ` Kevin Buettner
2002-08-01 13:54   ` Michael Snyder
2002-08-01 14:25     ` Andrew Cagney [this message]
2002-08-01 14:47       ` Michael Snyder
2002-08-01 16:38         ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D49A72F.7040108@ges.redhat.com \
    --to=ac131313@ges.redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox