From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4928 invoked by alias); 1 Aug 2002 21:25:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4921 invoked from network); 1 Aug 2002 21:25:20 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 1 Aug 2002 21:25:20 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 6CC763C63; Thu, 1 Aug 2002 17:25:03 -0400 (EDT) Message-ID: <3D49A72F.7040108@ges.redhat.com> Date: Thu, 01 Aug 2002 14:25:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Snyder , Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] 64-bit support for Irix 6 References: <1020731172757.ZM21630@localhost.localdomain> <3D494F95.5060708@ges.redhat.com> <3D499BCF.2E79188@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00021.txt.bz2 > Andrew Cagney wrote: > >> > >> > >> > #include "mips/tm-bigmips.h" >> > >> > +#undef MIPS_REGSIZE >> > +#define MIPS_REGSIZE 8 >> > + >> > /* SGI's assembler doesn't grok dollar signs in identifiers. >> > So we use dots instead. This item must be coordinated with G++. */ >> > #undef CPLUS_MARKER >> > @@ -89,11 +92,12 @@ >> > 32 * sizeof(double) + ((N) - 32) * MIPS_REGSIZE) >> > >> > #undef REGISTER_VIRTUAL_TYPE >> > +/* define 8 byte register type */ >> > #define REGISTER_VIRTUAL_TYPE(N) \ >> > (((N) >= FP0_REGNUM && (N) < FP0_REGNUM+32) ? builtin_type_double \ >> > : ((N) == 32 /*SR*/) ? builtin_type_uint32 \ >> > : ((N) >= 70 && (N) <= 89) ? builtin_type_uint32 \ >> > - : builtin_type_int) >> > + : builtin_type_long_long) >> > >> > /* Force N32 ABI as the default. */ >> > #define MIPS_DEFAULT_ABI MIPS_ABI_N32 >> > > >> >> Kevin, this is wrong. >> >> It is no longer acceptable to add support for an additional sub-target >> using non-multi-arch mechanisms. > > > Does that mean that if we touch a macro, we have to multi-arch it? If you want to fix a bug in a macro then you should first (separatly) convert it to a macro/function pair. I believe this is accepted as ``current best pratice''. If you want to change a bunch of macros to support an additional architecture variant then they need to be multi-arch. GDB no longer accepts an architecture variants that isn't multi-arch. > For instance, if we touch the PUSH_ARGUMENTS function, and > PUSH_ARGUMENTS > hasn't been multi-arched, do we have to multi-arch it? If you mean mips_push_arguments, then that is already part of the multi-arch vector. Just don't forget that any changes to that function should be multi-arch friendly. enjoy, Andrew