Re: [PATCH] 64-bit support for Irix 6

[Andrew Cagney <ac131313@ges.redhat.com>]

> On Aug 1, 11:11am, Andrew Cagney wrote:
> 
> 
>> Kevin, this is wrong.
>> 
>> It is no longer acceptable to add support for an additional sub-target 
>> using non-multi-arch mechanisms.
> 
> 
> How about this then?
> 
> 	* config/mips/tm-irix6.h: Include mips/tm-bigmips64.h instead of
> 	mips/tm-bigmips.h.
> 	(MIPS_REGSIZE, REGISTER_VIRTUAL_SIZE): Delete.

Even though it removes a macro, I think it is still fudging things.  The 
patch should be converting REGISTER_VIRTUAL_TYPE() to a function and 
then adding it to the multi-arch vector.

Add an #undef to tm-irix6.h.

Andrew


> Index: config/mips/tm-irix6.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/config/mips/tm-irix6.h,v
> retrieving revision 1.3
> diff -u -p -r1.3 tm-irix6.h
> --- config/mips/tm-irix6.h	31 Jul 2002 17:22:06 -0000	1.3
> +++ config/mips/tm-irix6.h	1 Aug 2002 16:33:24 -0000
> @@ -19,10 +19,7 @@
>     Foundation, Inc., 59 Temple Place - Suite 330,
>     Boston, MA 02111-1307, USA.  */
>  
> -#include "mips/tm-bigmips.h"
> -
> -#undef MIPS_REGSIZE
> -#define MIPS_REGSIZE 8
> +#include "mips/tm-bigmips64.h"
>  
>  /* SGI's assembler doesn't grok dollar signs in identifiers.
>     So we use dots instead.  This item must be coordinated with G++. */
> @@ -90,14 +87,6 @@
>        FP0_REGNUM * MIPS_REGSIZE + \
>        ((N) - FP0_REGNUM) * sizeof(double) : \
>        32 * sizeof(double) + ((N) - 32) * MIPS_REGSIZE)
> -
> -#undef  REGISTER_VIRTUAL_TYPE
> -/* define 8 byte register type */
> -#define REGISTER_VIRTUAL_TYPE(N) \
> -	(((N) >= FP0_REGNUM && (N) < FP0_REGNUM+32) ? builtin_type_double \
> -	 : ((N) == 32 /*SR*/) ? builtin_type_uint32 \
> -	 : ((N) >= 70 && (N) <= 89) ? builtin_type_uint32 \
> -	 : builtin_type_long_long)
>  
>  /* Force N32 ABI as the default. */
>  #define MIPS_DEFAULT_ABI MIPS_ABI_N32
> 
>