From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10171 invoked by alias); 1 Aug 2002 17:42:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10164 invoked from network); 1 Aug 2002 17:42:33 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 1 Aug 2002 17:42:33 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id C213B3C61; Thu, 1 Aug 2002 13:42:33 -0400 (EDT) Message-ID: <3D497309.7020300@ges.redhat.com> Date: Thu, 01 Aug 2002 10:42:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] 64-bit support for Irix 6 References: <1020731172757.ZM21630@localhost.localdomain> <3D494F95.5060708@ges.redhat.com> <1020801165318.ZM27591@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00006.txt.bz2 > On Aug 1, 11:11am, Andrew Cagney wrote: > > >> Kevin, this is wrong. >> >> It is no longer acceptable to add support for an additional sub-target >> using non-multi-arch mechanisms. > > > How about this then? > > * config/mips/tm-irix6.h: Include mips/tm-bigmips64.h instead of > mips/tm-bigmips.h. > (MIPS_REGSIZE, REGISTER_VIRTUAL_SIZE): Delete. Even though it removes a macro, I think it is still fudging things. The patch should be converting REGISTER_VIRTUAL_TYPE() to a function and then adding it to the multi-arch vector. Add an #undef to tm-irix6.h. Andrew > Index: config/mips/tm-irix6.h > =================================================================== > RCS file: /cvs/src/src/gdb/config/mips/tm-irix6.h,v > retrieving revision 1.3 > diff -u -p -r1.3 tm-irix6.h > --- config/mips/tm-irix6.h 31 Jul 2002 17:22:06 -0000 1.3 > +++ config/mips/tm-irix6.h 1 Aug 2002 16:33:24 -0000 > @@ -19,10 +19,7 @@ > Foundation, Inc., 59 Temple Place - Suite 330, > Boston, MA 02111-1307, USA. */ > > -#include "mips/tm-bigmips.h" > - > -#undef MIPS_REGSIZE > -#define MIPS_REGSIZE 8 > +#include "mips/tm-bigmips64.h" > > /* SGI's assembler doesn't grok dollar signs in identifiers. > So we use dots instead. This item must be coordinated with G++. */ > @@ -90,14 +87,6 @@ > FP0_REGNUM * MIPS_REGSIZE + \ > ((N) - FP0_REGNUM) * sizeof(double) : \ > 32 * sizeof(double) + ((N) - 32) * MIPS_REGSIZE) > - > -#undef REGISTER_VIRTUAL_TYPE > -/* define 8 byte register type */ > -#define REGISTER_VIRTUAL_TYPE(N) \ > - (((N) >= FP0_REGNUM && (N) < FP0_REGNUM+32) ? builtin_type_double \ > - : ((N) == 32 /*SR*/) ? builtin_type_uint32 \ > - : ((N) >= 70 && (N) <= 89) ? builtin_type_uint32 \ > - : builtin_type_long_long) > > /* Force N32 ABI as the default. */ > #define MIPS_DEFAULT_ABI MIPS_ABI_N32 > >