Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@ges.redhat.com>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Remove bogosities from dwarf2cfi.c:cfi_pop_frame()
Date: Mon, 08 Jul 2002 11:37:00 -0000	[thread overview]
Message-ID: <3D29DBB3.1080904@ges.redhat.com> (raw)
In-Reply-To: <200207072144.g67LioR02326@walton.kettenis.dyndns.org>

> Using alloca() here is pretty obvious.  I discussed the other fix with
> Michael Ludvig.
> 
> Checked in.
> 
> Mark
> 
> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* dwarf2cfi.c (cfi_pop_frame): Use alloca() for regbuf.
> 	Don't call get_current_frame().
> 

Heads up,

I think the write_register_bytes() call should be replaced by 
regcache_register_write(current_regcache, ).  This is new code so it 
doesn't need to go through any of that nasty write_register_bytes() stuff.

Andrew



  reply	other threads:[~2002-07-08 18:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-08  5:24 Mark Kettenis
2002-07-08 11:37 ` Andrew Cagney [this message]
2002-07-10  5:22   ` Richard Earnshaw
2002-07-10  9:43     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D29DBB3.1080904@ges.redhat.com \
    --to=ac131313@ges.redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox