From: Mark Kettenis <kettenis@chello.nl>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] Remove bogosities from dwarf2cfi.c:cfi_pop_frame()
Date: Mon, 08 Jul 2002 05:24:00 -0000 [thread overview]
Message-ID: <200207072144.g67LioR02326@walton.kettenis.dyndns.org> (raw)
Using alloca() here is pretty obvious. I discussed the other fix with
Michael Ludvig.
Checked in.
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* dwarf2cfi.c (cfi_pop_frame): Use alloca() for regbuf.
Don't call get_current_frame().
Index: dwarf2cfi.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2cfi.c,v
retrieving revision 1.11
diff -u -p -r1.11 dwarf2cfi.c
--- dwarf2cfi.c 21 Jun 2002 13:53:24 -0000 1.11
+++ dwarf2cfi.c 4 Jul 2002 14:40:22 -0000
@@ -1757,10 +1757,8 @@ cfi_write_fp (CORE_ADDR val)
void
cfi_pop_frame (struct frame_info *fi)
{
- char regbuf[MAX_REGISTER_RAW_SIZE];
+ char *regbuf = alloca (MAX_REGISTER_RAW_SIZE);
int regnum;
-
- fi = get_current_frame ();
for (regnum = 0; regnum < NUM_REGS; regnum++)
{
next reply other threads:[~2002-07-07 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-08 5:24 Mark Kettenis [this message]
2002-07-08 11:37 ` Andrew Cagney
2002-07-10 5:22 ` Richard Earnshaw
2002-07-10 9:43 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200207072144.g67LioR02326@walton.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox