From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12014 invoked by alias); 8 Jul 2002 18:36:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11981 invoked from network); 8 Jul 2002 18:36:39 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 8 Jul 2002 18:36:39 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id B9C423C65; Mon, 8 Jul 2002 14:36:35 -0400 (EDT) Message-ID: <3D29DBB3.1080904@ges.redhat.com> Date: Mon, 08 Jul 2002 11:37:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020613 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Remove bogosities from dwarf2cfi.c:cfi_pop_frame() References: <200207072144.g67LioR02326@walton.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-07/txt/msg00118.txt.bz2 > Using alloca() here is pretty obvious. I discussed the other fix with > Michael Ludvig. > > Checked in. > > Mark > > Index: ChangeLog > from Mark Kettenis > > * dwarf2cfi.c (cfi_pop_frame): Use alloca() for regbuf. > Don't call get_current_frame(). > Heads up, I think the write_register_bytes() call should be replaced by regcache_register_write(current_regcache, ). This is new code so it doesn't need to go through any of that nasty write_register_bytes() stuff. Andrew