Re: [PATCH] m68k multi-arch: frame_saved_regs

[Andrew Cagney <ac131313@cygnus.com>]

Just some tweaks (Eli might have to correct me :-)

> 2002-06-20  Grace Sainsbury  <graces@redhat.com>
> 
>         * m68k-tdep.c (m68k_frame_init_saved_regs): Replaced
>         m68k_find_saved_regs.

I think a ChangeLog uses present tense ``Replace m68k...''.

>         (m68k_pop_frame): Removed saved_regs structure, and replaced
>         references to it with frasme->saved_regs.
>         (m68k_gdbarch_init): Added function calls to initialize the
>         gdbarch structure. 
>         * config/m68k/tm-m68k.h: Removed FRAME_FIND_SAVED_REGS and
>         macros associated with CALL_DUMMY

Remember to provide the complete list.  At some stage in the future 
someone will be looking at this and wondering exactly which macros they 
were.  This sometimes leads to very long ChangeLog entries but we live 
with that :-).  Trailing period.

* config/.....h (RFRAME)FIND_SAVED_REGS): Remove.
(CALL_DUMMY): Delete.
...

+m68k_fix_call_dummy(char *dummy, CORE_ADDR pc, CORE_ADDR fun, int nargs,

Just, suggest running the file through indent (``..._dummy (...'').

That wacks the hardest ones! ya.
Andrew