From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16428-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 15505 invoked by alias); 21 Jun 2002 15:03:00 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15486 invoked from network); 21 Jun 2002 15:02:57 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 21 Jun 2002 15:02:57 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 8D8BA3E76; Fri, 21 Jun 2002 11:02:57 -0400 (EDT)
Message-ID: <3D134021.1060508@cygnus.com>
Date: Fri, 21 Jun 2002 08:03:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020613
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Grace Sainsbury <graces@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] m68k multi-arch: frame_saved_regs
References: <20020621102211.A22931@tomago.toronto.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-06/txt/msg00422.txt.bz2

Just some tweaks (Eli might have to correct me :-)

> 2002-06-20  Grace Sainsbury  <graces@redhat.com>
> 
>         * m68k-tdep.c (m68k_frame_init_saved_regs): Replaced
>         m68k_find_saved_regs.

I think a ChangeLog uses present tense ``Replace m68k...''.

>         (m68k_pop_frame): Removed saved_regs structure, and replaced
>         references to it with frasme->saved_regs.
>         (m68k_gdbarch_init): Added function calls to initialize the
>         gdbarch structure. 
>         * config/m68k/tm-m68k.h: Removed FRAME_FIND_SAVED_REGS and
>         macros associated with CALL_DUMMY

Remember to provide the complete list.  At some stage in the future 
someone will be looking at this and wondering exactly which macros they 
were.  This sometimes leads to very long ChangeLog entries but we live 
with that :-).  Trailing period.

* config/.....h (RFRAME)FIND_SAVED_REGS): Remove.
(CALL_DUMMY): Delete.
...

+m68k_fix_call_dummy(char *dummy, CORE_ADDR pc, CORE_ADDR fun, int nargs,

Just, suggest running the file through indent (``..._dummy (...'').

That wacks the hardest ones! ya.
Andrew