From: Grace Sainsbury <graces@redhat.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] m68k multi-arch: frame_saved_regs
Date: Fri, 21 Jun 2002 08:27:00 -0000 [thread overview]
Message-ID: <20020621112723.A23061@tomago.toronto.redhat.com> (raw)
In-Reply-To: <3D134021.1060508@cygnus.com>; from ac131313@cygnus.com on Fri, Jun 21, 2002 at 11:02:57AM -0400
I fixed the ChangeLog and indented m68k-tdep.
the ne ChangeLog:
2002-06-21 Grace Sainsbury <graces@redhat.com>
* m68k-tdep.c (m68k_frame_init_saved_regs): Replace
m68k_find_saved_regs.
(m68k_pop_frame): Removed saved_regs structure, and replaced
references to it with frasme->saved_regs.
(m68k_gdbarch_init): Added function calls to initialize the
gdbarch structure.
(m68k_fix_call_dummy): Add.
* config/m68k/tm-m68k.h: (FRAME_FIND_SAVED_REGS): Remove.
(CALL_DUMMY): Remove.
(CALL_DUMMY_LENGTH): Remove.
(CALL_DUMMY_START_OFFSET): Remove.
(CALL_DUMMY_BREAKPOINT_OFFSET): Remove.
(FIX_CALL_DUMMY): Remove.
(PUSH_DUMMY_FRAME): Remove.
(POP_FRAME): Remove.
is it ok to commit.
grace
On Fri, Jun 21, 2002 at 11:02:57AM -0400, Andrew Cagney wrote:
> Just some tweaks (Eli might have to correct me :-)
>
> > 2002-06-20 Grace Sainsbury <graces@redhat.com>
> >
> > * m68k-tdep.c (m68k_frame_init_saved_regs): Replaced
> > m68k_find_saved_regs.
>
> I think a ChangeLog uses present tense ``Replace m68k...''.
>
> > (m68k_pop_frame): Removed saved_regs structure, and replaced
> > references to it with frasme->saved_regs.
> > (m68k_gdbarch_init): Added function calls to initialize the
> > gdbarch structure.
> > * config/m68k/tm-m68k.h: Removed FRAME_FIND_SAVED_REGS and
> > macros associated with CALL_DUMMY
>
> Remember to provide the complete list. At some stage in the future
> someone will be looking at this and wondering exactly which macros they
> were. This sometimes leads to very long ChangeLog entries but we live
> with that :-). Trailing period.
>
> * config/.....h (RFRAME)FIND_SAVED_REGS): Remove.
> (CALL_DUMMY): Delete.
> ...
>
> +m68k_fix_call_dummy(char *dummy, CORE_ADDR pc, CORE_ADDR fun, int nargs,
>
> Just, suggest running the file through indent (``..._dummy (...'').
>
> That wacks the hardest ones! ya.
> Andrew
>
>
next prev parent reply other threads:[~2002-06-21 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-21 7:22 Grace Sainsbury
2002-06-21 8:03 ` Andrew Cagney
2002-06-21 8:27 ` Grace Sainsbury [this message]
2002-06-21 8:42 ` Andrew Cagney
2002-06-21 9:27 ` Jason R Thorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020621112723.A23061@tomago.toronto.redhat.com \
--to=graces@redhat.com \
--cc=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox