From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16430-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 24248 invoked by alias); 21 Jun 2002 15:27:28 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24216 invoked from network); 21 Jun 2002 15:27:25 -0000
Received: from unknown (HELO tomago.toronto.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 21 Jun 2002 15:27:25 -0000
Received: (from graces@localhost)
	by tomago.toronto.redhat.com (8.11.6/8.11.6) id g5LFRNY23110;
	Fri, 21 Jun 2002 11:27:23 -0400
Date: Fri, 21 Jun 2002 08:27:00 -0000
From: Grace Sainsbury <graces@redhat.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] m68k multi-arch: frame_saved_regs
Message-ID: <20020621112723.A23061@tomago.toronto.redhat.com>
References: <20020621102211.A22931@tomago.toronto.redhat.com> <3D134021.1060508@cygnus.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <3D134021.1060508@cygnus.com>; from ac131313@cygnus.com on Fri, Jun 21, 2002 at 11:02:57AM -0400
X-SW-Source: 2002-06/txt/msg00424.txt.bz2

I fixed the ChangeLog and indented m68k-tdep.

the ne ChangeLog:

2002-06-21  Grace Sainsbury  <graces@redhat.com>

	* m68k-tdep.c (m68k_frame_init_saved_regs): Replace
        m68k_find_saved_regs.
        (m68k_pop_frame): Removed saved_regs structure, and replaced
        references to it with frasme->saved_regs.
        (m68k_gdbarch_init): Added function calls to initialize the
        gdbarch structure.
	(m68k_fix_call_dummy): Add. 
	* config/m68k/tm-m68k.h: (FRAME_FIND_SAVED_REGS): Remove.
       	(CALL_DUMMY): Remove.
	(CALL_DUMMY_LENGTH): Remove.
	(CALL_DUMMY_START_OFFSET): Remove.
	(CALL_DUMMY_BREAKPOINT_OFFSET): Remove.
	(FIX_CALL_DUMMY): Remove.
	(PUSH_DUMMY_FRAME): Remove.
	(POP_FRAME): Remove.

is it ok to commit.

grace

On Fri, Jun 21, 2002 at 11:02:57AM -0400, Andrew Cagney wrote:
> Just some tweaks (Eli might have to correct me :-)
> 
> > 2002-06-20  Grace Sainsbury  <graces@redhat.com>
> > 
> >         * m68k-tdep.c (m68k_frame_init_saved_regs): Replaced
> >         m68k_find_saved_regs.
> 
> I think a ChangeLog uses present tense ``Replace m68k...''.
> 
> >         (m68k_pop_frame): Removed saved_regs structure, and replaced
> >         references to it with frasme->saved_regs.
> >         (m68k_gdbarch_init): Added function calls to initialize the
> >         gdbarch structure. 
> >         * config/m68k/tm-m68k.h: Removed FRAME_FIND_SAVED_REGS and
> >         macros associated with CALL_DUMMY
> 
> Remember to provide the complete list.  At some stage in the future 
> someone will be looking at this and wondering exactly which macros they 
> were.  This sometimes leads to very long ChangeLog entries but we live 
> with that :-).  Trailing period.
> 
> * config/.....h (RFRAME)FIND_SAVED_REGS): Remove.
> (CALL_DUMMY): Delete.
> ...
> 
> +m68k_fix_call_dummy(char *dummy, CORE_ADDR pc, CORE_ADDR fun, int nargs,
> 
> Just, suggest running the file through indent (``..._dummy (...'').
> 
> That wacks the hardest ones! ya.
> Andrew
> 
>