* RFA: PATCH: indent m68k-tdep.c
@ 2002-06-17 12:35 Grace Sainsbury
2002-06-17 13:04 ` Andrew Cagney
2002-06-18 14:37 ` Michael Snyder
0 siblings, 2 replies; 3+ messages in thread
From: Grace Sainsbury @ 2002-06-17 12:35 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
This indents m68k-tdep.c using gdb_indent.sh. Is it ok to commit?
Grace Sainsbury
2002-06-17 Grace Sainsbury <graces@redhat.com>
* m68k-tdep.c: Reindent.
[-- Attachment #2: indent_m68k.diff --]
[-- Type: text/plain, Size: 3491 bytes --]
Index: m68k-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m68k-tdep.c,v
retrieving revision 1.14
diff -u -r1.14 m68k-tdep.c
--- m68k-tdep.c 1 Dec 2001 23:06:46 -0000 1.14
+++ m68k-tdep.c 17 Jun 2002 18:59:07 -0000
@@ -81,11 +81,11 @@
return frame_info->frame + 12;
else if (frameless_look_for_prologue (frame_info))
{
- /* Check for an interrupted system call */
- if (frame_info->next && frame_info->next->signal_handler_caller)
- return frame_info->next->frame + 16;
- else
- return frame_info->frame + 4;
+ /* Check for an interrupted system call */
+ if (frame_info->next && frame_info->next->signal_handler_caller)
+ return frame_info->next->frame + 16;
+ else
+ return frame_info->frame + 4;
}
else
return frame_info->frame;
@@ -226,7 +226,8 @@
}
if (fsr.regs[PS_REGNUM])
{
- write_register (PS_REGNUM, read_memory_integer (fsr.regs[PS_REGNUM], 4));
+ write_register (PS_REGNUM,
+ read_memory_integer (fsr.regs[PS_REGNUM], 4));
}
write_register (FP_REGNUM, read_memory_integer (fp, 4));
write_register (PC_REGNUM, read_memory_integer (fp + 4, 4));
@@ -278,7 +279,7 @@
If so, ensure we don't go past it. If not, assume "infinity". */
sal = find_pc_line (ip, 0);
- limit = (sal.end) ? sal.end : (CORE_ADDR) ~ 0;
+ limit = (sal.end) ? sal.end : (CORE_ADDR) ~0;
while (ip < limit)
{
@@ -298,7 +299,7 @@
else if (op == P_FMOVM)
ip += 10; /* Skip fmovm */
else
- break; /* Found unknown code, bail out. */
+ break; /* Found unknown code, bail out. */
}
return (ip);
}
@@ -314,7 +315,7 @@
/* First possible address for a pc in a call dummy for this frame. */
CORE_ADDR possible_call_dummy_start =
- (frame_info)->frame - CALL_DUMMY_LENGTH - FP_REGNUM * 4 - 4 - 8 * 12;
+ (frame_info)->frame - CALL_DUMMY_LENGTH - FP_REGNUM * 4 - 4 - 8 * 12;
int nextinsn;
memset (saved_regs, 0, sizeof (*saved_regs));
@@ -367,7 +368,7 @@
next_addr += read_memory_integer (pc += 2, 4), pc += 4;
}
- for ( ; ; )
+ for (;;)
{
nextinsn = 0xffff & read_memory_integer (pc, 2);
regmask = read_memory_integer (pc + 2, 2);
@@ -519,7 +520,7 @@
register values. */
void
-supply_gregset (gregset_t *gregsetp)
+supply_gregset (gregset_t * gregsetp)
{
register int regi;
register greg_t *regp = (greg_t *) gregsetp;
@@ -533,7 +534,7 @@
}
void
-fill_gregset (gregset_t *gregsetp, int regno)
+fill_gregset (gregset_t * gregsetp, int regno)
{
register int regi;
register greg_t *regp = (greg_t *) gregsetp;
@@ -562,7 +563,7 @@
idea of the current floating point register values. */
void
-supply_fpregset (fpregset_t *fpregsetp)
+supply_fpregset (fpregset_t * fpregsetp)
{
register int regi;
char *from;
@@ -583,7 +584,7 @@
them all. */
void
-fill_fpregset (fpregset_t *fpregsetp, int regno)
+fill_fpregset (fpregset_t * fpregsetp, int regno)
{
int regi;
char *to;
@@ -636,9 +637,8 @@
buf = alloca (TARGET_PTR_BIT / TARGET_CHAR_BIT);
sp = read_register (SP_REGNUM);
- if (target_read_memory (sp + SP_ARG0, /* Offset of first arg on stack */
- buf,
- TARGET_PTR_BIT / TARGET_CHAR_BIT))
+ if (target_read_memory (sp + SP_ARG0, /* Offset of first arg on stack */
+ buf, TARGET_PTR_BIT / TARGET_CHAR_BIT))
return 0;
jb_addr = extract_address (buf, TARGET_PTR_BIT / TARGET_CHAR_BIT);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: RFA: PATCH: indent m68k-tdep.c
2002-06-17 12:35 RFA: PATCH: indent m68k-tdep.c Grace Sainsbury
@ 2002-06-17 13:04 ` Andrew Cagney
2002-06-18 14:37 ` Michael Snyder
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cagney @ 2002-06-17 13:04 UTC (permalink / raw)
To: Grace Sainsbury; +Cc: gdb-patches
> 2002-06-17 Grace Sainsbury <graces@redhat.com>
>
> * m68k-tdep.c: Reindent.
>
Yes, ok. Please also feel free to add yourself to the gdb/MAINTAINERS
file under write after approval (separate patch).
> void
> -fill_gregset (gregset_t *gregsetp, int regno)
> +fill_gregset (gregset_t * gregsetp, int regno)
> {
Hmm, I've [just] committed a fix for this - bug in gdb_indent.sh.
Before committing the above, can you run the file through gdb_indent.sh
again (no need to re-post the patch).
enjoy,
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: RFA: PATCH: indent m68k-tdep.c
2002-06-17 12:35 RFA: PATCH: indent m68k-tdep.c Grace Sainsbury
2002-06-17 13:04 ` Andrew Cagney
@ 2002-06-18 14:37 ` Michael Snyder
1 sibling, 0 replies; 3+ messages in thread
From: Michael Snyder @ 2002-06-18 14:37 UTC (permalink / raw)
To: Grace Sainsbury; +Cc: gdb-patches
Grace Sainsbury wrote:
>
> This indents m68k-tdep.c using gdb_indent.sh. Is it ok to commit?
>
> Grace Sainsbury
[Doning Cap of Omnipotence]
Looks fine to me. Please commit.
>
> 2002-06-17 Grace Sainsbury <graces@redhat.com>
>
> * m68k-tdep.c: Reindent.
>
> ------------------------------------------------------------------------
> Index: m68k-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/m68k-tdep.c,v
> retrieving revision 1.14
> diff -u -r1.14 m68k-tdep.c
> --- m68k-tdep.c 1 Dec 2001 23:06:46 -0000 1.14
> +++ m68k-tdep.c 17 Jun 2002 18:59:07 -0000
> @@ -81,11 +81,11 @@
> return frame_info->frame + 12;
> else if (frameless_look_for_prologue (frame_info))
> {
> - /* Check for an interrupted system call */
> - if (frame_info->next && frame_info->next->signal_handler_caller)
> - return frame_info->next->frame + 16;
> - else
> - return frame_info->frame + 4;
> + /* Check for an interrupted system call */
> + if (frame_info->next && frame_info->next->signal_handler_caller)
> + return frame_info->next->frame + 16;
> + else
> + return frame_info->frame + 4;
> }
> else
> return frame_info->frame;
> @@ -226,7 +226,8 @@
> }
> if (fsr.regs[PS_REGNUM])
> {
> - write_register (PS_REGNUM, read_memory_integer (fsr.regs[PS_REGNUM], 4));
> + write_register (PS_REGNUM,
> + read_memory_integer (fsr.regs[PS_REGNUM], 4));
> }
> write_register (FP_REGNUM, read_memory_integer (fp, 4));
> write_register (PC_REGNUM, read_memory_integer (fp + 4, 4));
> @@ -278,7 +279,7 @@
> If so, ensure we don't go past it. If not, assume "infinity". */
>
> sal = find_pc_line (ip, 0);
> - limit = (sal.end) ? sal.end : (CORE_ADDR) ~ 0;
> + limit = (sal.end) ? sal.end : (CORE_ADDR) ~0;
>
> while (ip < limit)
> {
> @@ -298,7 +299,7 @@
> else if (op == P_FMOVM)
> ip += 10; /* Skip fmovm */
> else
> - break; /* Found unknown code, bail out. */
> + break; /* Found unknown code, bail out. */
> }
> return (ip);
> }
> @@ -314,7 +315,7 @@
>
> /* First possible address for a pc in a call dummy for this frame. */
> CORE_ADDR possible_call_dummy_start =
> - (frame_info)->frame - CALL_DUMMY_LENGTH - FP_REGNUM * 4 - 4 - 8 * 12;
> + (frame_info)->frame - CALL_DUMMY_LENGTH - FP_REGNUM * 4 - 4 - 8 * 12;
>
> int nextinsn;
> memset (saved_regs, 0, sizeof (*saved_regs));
> @@ -367,7 +368,7 @@
> next_addr += read_memory_integer (pc += 2, 4), pc += 4;
> }
>
> - for ( ; ; )
> + for (;;)
> {
> nextinsn = 0xffff & read_memory_integer (pc, 2);
> regmask = read_memory_integer (pc + 2, 2);
> @@ -519,7 +520,7 @@
> register values. */
>
> void
> -supply_gregset (gregset_t *gregsetp)
> +supply_gregset (gregset_t * gregsetp)
> {
> register int regi;
> register greg_t *regp = (greg_t *) gregsetp;
> @@ -533,7 +534,7 @@
> }
>
> void
> -fill_gregset (gregset_t *gregsetp, int regno)
> +fill_gregset (gregset_t * gregsetp, int regno)
> {
> register int regi;
> register greg_t *regp = (greg_t *) gregsetp;
> @@ -562,7 +563,7 @@
> idea of the current floating point register values. */
>
> void
> -supply_fpregset (fpregset_t *fpregsetp)
> +supply_fpregset (fpregset_t * fpregsetp)
> {
> register int regi;
> char *from;
> @@ -583,7 +584,7 @@
> them all. */
>
> void
> -fill_fpregset (fpregset_t *fpregsetp, int regno)
> +fill_fpregset (fpregset_t * fpregsetp, int regno)
> {
> int regi;
> char *to;
> @@ -636,9 +637,8 @@
> buf = alloca (TARGET_PTR_BIT / TARGET_CHAR_BIT);
> sp = read_register (SP_REGNUM);
>
> - if (target_read_memory (sp + SP_ARG0, /* Offset of first arg on stack */
> - buf,
> - TARGET_PTR_BIT / TARGET_CHAR_BIT))
> + if (target_read_memory (sp + SP_ARG0, /* Offset of first arg on stack */
> + buf, TARGET_PTR_BIT / TARGET_CHAR_BIT))
> return 0;
>
> jb_addr = extract_address (buf, TARGET_PTR_BIT / TARGET_CHAR_BIT);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-06-18 21:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-06-17 12:35 RFA: PATCH: indent m68k-tdep.c Grace Sainsbury
2002-06-17 13:04 ` Andrew Cagney
2002-06-18 14:37 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox