From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30824 invoked by alias); 18 Jun 2002 21:37:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30756 invoked from network); 18 Jun 2002 21:37:22 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 18 Jun 2002 21:37:22 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA22516; Tue, 18 Jun 2002 14:37:20 -0700 (PDT) Message-ID: <3D0FA449.DD922D6D@redhat.com> Date: Tue, 18 Jun 2002 14:37:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Grace Sainsbury CC: gdb-patches@sources.redhat.com Subject: Re: RFA: PATCH: indent m68k-tdep.c References: <3D0E3A0B.674F1B69@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-06/txt/msg00338.txt.bz2 Grace Sainsbury wrote: > > This indents m68k-tdep.c using gdb_indent.sh. Is it ok to commit? > > Grace Sainsbury [Doning Cap of Omnipotence] Looks fine to me. Please commit. > > 2002-06-17 Grace Sainsbury > > * m68k-tdep.c: Reindent. > > ------------------------------------------------------------------------ > Index: m68k-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/m68k-tdep.c,v > retrieving revision 1.14 > diff -u -r1.14 m68k-tdep.c > --- m68k-tdep.c 1 Dec 2001 23:06:46 -0000 1.14 > +++ m68k-tdep.c 17 Jun 2002 18:59:07 -0000 > @@ -81,11 +81,11 @@ > return frame_info->frame + 12; > else if (frameless_look_for_prologue (frame_info)) > { > - /* Check for an interrupted system call */ > - if (frame_info->next && frame_info->next->signal_handler_caller) > - return frame_info->next->frame + 16; > - else > - return frame_info->frame + 4; > + /* Check for an interrupted system call */ > + if (frame_info->next && frame_info->next->signal_handler_caller) > + return frame_info->next->frame + 16; > + else > + return frame_info->frame + 4; > } > else > return frame_info->frame; > @@ -226,7 +226,8 @@ > } > if (fsr.regs[PS_REGNUM]) > { > - write_register (PS_REGNUM, read_memory_integer (fsr.regs[PS_REGNUM], 4)); > + write_register (PS_REGNUM, > + read_memory_integer (fsr.regs[PS_REGNUM], 4)); > } > write_register (FP_REGNUM, read_memory_integer (fp, 4)); > write_register (PC_REGNUM, read_memory_integer (fp + 4, 4)); > @@ -278,7 +279,7 @@ > If so, ensure we don't go past it. If not, assume "infinity". */ > > sal = find_pc_line (ip, 0); > - limit = (sal.end) ? sal.end : (CORE_ADDR) ~ 0; > + limit = (sal.end) ? sal.end : (CORE_ADDR) ~0; > > while (ip < limit) > { > @@ -298,7 +299,7 @@ > else if (op == P_FMOVM) > ip += 10; /* Skip fmovm */ > else > - break; /* Found unknown code, bail out. */ > + break; /* Found unknown code, bail out. */ > } > return (ip); > } > @@ -314,7 +315,7 @@ > > /* First possible address for a pc in a call dummy for this frame. */ > CORE_ADDR possible_call_dummy_start = > - (frame_info)->frame - CALL_DUMMY_LENGTH - FP_REGNUM * 4 - 4 - 8 * 12; > + (frame_info)->frame - CALL_DUMMY_LENGTH - FP_REGNUM * 4 - 4 - 8 * 12; > > int nextinsn; > memset (saved_regs, 0, sizeof (*saved_regs)); > @@ -367,7 +368,7 @@ > next_addr += read_memory_integer (pc += 2, 4), pc += 4; > } > > - for ( ; ; ) > + for (;;) > { > nextinsn = 0xffff & read_memory_integer (pc, 2); > regmask = read_memory_integer (pc + 2, 2); > @@ -519,7 +520,7 @@ > register values. */ > > void > -supply_gregset (gregset_t *gregsetp) > +supply_gregset (gregset_t * gregsetp) > { > register int regi; > register greg_t *regp = (greg_t *) gregsetp; > @@ -533,7 +534,7 @@ > } > > void > -fill_gregset (gregset_t *gregsetp, int regno) > +fill_gregset (gregset_t * gregsetp, int regno) > { > register int regi; > register greg_t *regp = (greg_t *) gregsetp; > @@ -562,7 +563,7 @@ > idea of the current floating point register values. */ > > void > -supply_fpregset (fpregset_t *fpregsetp) > +supply_fpregset (fpregset_t * fpregsetp) > { > register int regi; > char *from; > @@ -583,7 +584,7 @@ > them all. */ > > void > -fill_fpregset (fpregset_t *fpregsetp, int regno) > +fill_fpregset (fpregset_t * fpregsetp, int regno) > { > int regi; > char *to; > @@ -636,9 +637,8 @@ > buf = alloca (TARGET_PTR_BIT / TARGET_CHAR_BIT); > sp = read_register (SP_REGNUM); > > - if (target_read_memory (sp + SP_ARG0, /* Offset of first arg on stack */ > - buf, > - TARGET_PTR_BIT / TARGET_CHAR_BIT)) > + if (target_read_memory (sp + SP_ARG0, /* Offset of first arg on stack */ > + buf, TARGET_PTR_BIT / TARGET_CHAR_BIT)) > return 0; > > jb_addr = extract_address (buf, TARGET_PTR_BIT / TARGET_CHAR_BIT);