From: Andrew Cagney <ac131313@cygnus.com>
To: Michal Ludvig <mludvig@suse.cz>
Cc: GDB Patches <gdb-patches@sources.redhat.com>,
Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [RFA] dwarf2cfi.c improvements
Date: Mon, 03 Jun 2002 06:43:00 -0000 [thread overview]
Message-ID: <3CFB727E.10005@cygnus.com> (raw)
In-Reply-To: <3CF79DA0.9040404@suse.cz>
> internal_error (__FILE__, __LINE__,
> ! "%s: unknown pointer encoding: 0x%x",
> ! __func__, encoding);
> }
Michael,
Just FYI, __func__ can't be used. It isn't considered part of the ISO C
that GDB builds to.
> ! error ("%s: CFA is not defined as CFA_REG_OFFSET", __func__);
Hmm, I don't think user error messages need to include function names.
Can I suggest pulling the error() and internal_error() message changes
out, cleaning them up, and then committing them separatly. Better
messages (eg printing the reason for a bad switch) are always a good idea.
That also has the benefit of trimming your patch back.
enjoy,
Andrew
next prev parent reply other threads:[~2002-06-03 13:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-31 10:21 Michal Ludvig
2002-06-03 6:43 ` Andrew Cagney [this message]
2002-06-04 4:35 ` Michal Ludvig
2002-06-10 20:21 ` Elena Zannoni
2002-06-11 8:28 ` Michal Ludvig
2002-06-11 8:56 ` Daniel Jacobowitz
2002-06-11 14:00 ` Elena Zannoni
[not found] ` <3D08EB06.9030200@suse.cz>
2002-06-19 6:48 ` Elena Zannoni
2002-06-19 6:48 ` Elena Zannoni
2002-06-13 12:02 Michal Ludvig
2002-07-18 5:54 Michal Ludvig
2002-07-18 16:53 ` Jim Blandy
2002-07-19 10:49 ` Andrew Cagney
2002-07-19 12:56 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CFB727E.10005@cygnus.com \
--to=ac131313@cygnus.com \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mludvig@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox