From: Daniel Jacobowitz <drow@mvista.com>
To: Michal Ludvig <mludvig@suse.cz>
Cc: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] dwarf2cfi.c improvements
Date: Tue, 11 Jun 2002 08:56:00 -0000 [thread overview]
Message-ID: <20020611155305.GA18151@nevyn.them.org> (raw)
In-Reply-To: <3D06171B.3040709@suse.cz>
On Tue, Jun 11, 2002 at 05:28:27PM +0200, Michal Ludvig wrote:
> Elena Zannoni wrote:
> >Michal Ludvig writes:
> > >
> > > Well, this is the patch without unrelated message changes. Can I commit
> > > it? It seems to be quite stable in our everyday use...
> > >
> >
> >Michal, sorry, not as is.
>
> No problem, I'll rework it.
>
> >There are coding standard violations having to do with spaces before
> >'(' and after ')' in casts. Also, it is better to not have multiple
> >initializations in a single line, like this:
> > > ! char *start = NULL, *end = NULL, *frame_buffer = NULL;
>
> Changed. I've reindented the whole file. I hope running 'indent
> dwarf2cfi.c' is enough.
Try gdb_indent.sh in the source directory.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-06-11 15:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-31 10:21 Michal Ludvig
2002-06-03 6:43 ` Andrew Cagney
2002-06-04 4:35 ` Michal Ludvig
2002-06-10 20:21 ` Elena Zannoni
2002-06-11 8:28 ` Michal Ludvig
2002-06-11 8:56 ` Daniel Jacobowitz [this message]
2002-06-11 14:00 ` Elena Zannoni
[not found] ` <3D08EB06.9030200@suse.cz>
2002-06-19 6:48 ` Elena Zannoni
2002-06-19 6:48 ` Elena Zannoni
2002-06-13 12:02 Michal Ludvig
2002-07-18 5:54 Michal Ludvig
2002-07-18 16:53 ` Jim Blandy
2002-07-19 10:49 ` Andrew Cagney
2002-07-19 12:56 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020611155305.GA18151@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mludvig@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox