From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15511 invoked by alias); 11 Jun 2002 15:56:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15446 invoked from network); 11 Jun 2002 15:56:50 -0000 Received: from unknown (HELO nevyn.them.org) (66.19.120.17) by sources.redhat.com with SMTP; 11 Jun 2002 15:56:50 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17HnxB-0004m2-00; Tue, 11 Jun 2002 11:53:05 -0400 Date: Tue, 11 Jun 2002 08:56:00 -0000 From: Daniel Jacobowitz To: Michal Ludvig Cc: GDB Patches Subject: Re: [RFA] dwarf2cfi.c improvements Message-ID: <20020611155305.GA18151@nevyn.them.org> Mail-Followup-To: Michal Ludvig , GDB Patches References: <3CF79DA0.9040404@suse.cz> <3CFB727E.10005@cygnus.com> <3CFCA5ED.7010201@suse.cz> <15621.27804.562409.937859@localhost.redhat.com> <3D06171B.3040709@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D06171B.3040709@suse.cz> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-06/txt/msg00174.txt.bz2 On Tue, Jun 11, 2002 at 05:28:27PM +0200, Michal Ludvig wrote: > Elena Zannoni wrote: > >Michal Ludvig writes: > > > > > > Well, this is the patch without unrelated message changes. Can I commit > > > it? It seems to be quite stable in our everyday use... > > > > > > >Michal, sorry, not as is. > > No problem, I'll rework it. > > >There are coding standard violations having to do with spaces before > >'(' and after ')' in casts. Also, it is better to not have multiple > >initializations in a single line, like this: > > > ! char *start = NULL, *end = NULL, *frame_buffer = NULL; > > Changed. I've reindented the whole file. I hope running 'indent > dwarf2cfi.c' is enough. Try gdb_indent.sh in the source directory. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer