From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32691 invoked by alias); 3 Jun 2002 13:43:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32677 invoked from network); 3 Jun 2002 13:43:14 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 3 Jun 2002 13:43:14 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E0E0A3EB4; Mon, 3 Jun 2002 09:43:26 -0400 (EDT) Message-ID: <3CFB727E.10005@cygnus.com> Date: Mon, 03 Jun 2002 06:43:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc3) Gecko/20020530 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michal Ludvig Cc: GDB Patches , Elena Zannoni Subject: Re: [RFA] dwarf2cfi.c improvements References: <3CF79DA0.9040404@suse.cz> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-06/txt/msg00039.txt.bz2 > internal_error (__FILE__, __LINE__, > ! "%s: unknown pointer encoding: 0x%x", > ! __func__, encoding); > } Michael, Just FYI, __func__ can't be used. It isn't considered part of the ISO C that GDB builds to. > ! error ("%s: CFA is not defined as CFA_REG_OFFSET", __func__); Hmm, I don't think user error messages need to include function names. Can I suggest pulling the error() and internal_error() message changes out, cleaning them up, and then committing them separatly. Better messages (eg printing the reason for a bad switch) are always a good idea. That also has the benefit of trimming your patch back. enjoy, Andrew