Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/MI] Renumber enum mi_cmd_result
Date: Fri, 17 May 2002 14:43:00 -0000	[thread overview]
Message-ID: <3CE5799A.30605@cygnus.com> (raw)
In-Reply-To: <Pine.GSO.4.33.0205171417280.2236-100000@makita.cygnus.com>

> Hi,
> 
> I've been looking over Apple's MI changes, so expect to see quite a few
> questions/changes/patches/debates/documentation updates/etc in the coming
> weeks on MI.
> 
> This simple patch renumbers enum mi_cmd_result so that it starts at one
> instead of zero. This is necessary because MI_CMD_DONE would be
> indistinguishable from an error condition (both would return zero to
> catch_errors).
> 
> I have run the testsuite before and after this change, and it produces no
> differences.
> 
> (Okay, this is almost too simple to leave by itself, but, gotta start
> somewhere!)
> 
> Keith
> 
> ChangeLog
> 2002-05-17  Keith Seitz  <keiths@redhat.com>
> 
>         From Jim Ingham <jingham at apple dot com>:
>         * mi-cmds.h (enum mi_cmd_result): Start numbering at one instead
>         of zero so that errors can be distinguished from other status
>         returns.
> 
Keith,

Check catch_exceptions().  The whole catch_errors() argument problem has 
been fixed.  I'd consider a switch to catch_exceptions obvious and I can 
see only one call.

Andrew



  reply	other threads:[~2002-05-17 21:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-17 14:29 Keith Seitz
2002-05-17 14:43 ` Andrew Cagney [this message]
2002-05-17 14:47   ` Keith Seitz
2002-05-20 10:08   ` Keith Seitz
2002-05-20 10:34     ` Andrew Cagney
2002-05-20 11:10       ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CE5799A.30605@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox