Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: <gdb-patches@sources.redhat.com>
Subject: [RFC/MI] Renumber enum mi_cmd_result
Date: Fri, 17 May 2002 14:29:00 -0000	[thread overview]
Message-ID: <Pine.GSO.4.33.0205171417280.2236-100000@makita.cygnus.com> (raw)

Hi,

I've been looking over Apple's MI changes, so expect to see quite a few
questions/changes/patches/debates/documentation updates/etc in the coming
weeks on MI.

This simple patch renumbers enum mi_cmd_result so that it starts at one
instead of zero. This is necessary because MI_CMD_DONE would be
indistinguishable from an error condition (both would return zero to
catch_errors).

I have run the testsuite before and after this change, and it produces no
differences.

(Okay, this is almost too simple to leave by itself, but, gotta start
somewhere!)

Keith

ChangeLog
2002-05-17  Keith Seitz  <keiths@redhat.com>

        From Jim Ingham <jingham at apple dot com>:
        * mi-cmds.h (enum mi_cmd_result): Start numbering at one instead
        of zero so that errors can be distinguished from other status
        returns.

Patch
Index: mi/mi-cmds.h
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-cmds.h,v
retrieving revision 1.5
diff -p -r1.5 mi-cmds.h
*** mi/mi-cmds.h	6 Mar 2001 08:21:45 -0000	1.5
--- mi/mi-cmds.h	17 May 2002 21:14:43 -0000
***************
*** 27,34 ****
  enum mi_cmd_result
    {
      /* Report the command as ``done''.  Display both the ``NNN^done''
!        message and the completion prompt.  */
!     MI_CMD_DONE = 0,
      /* The command is still running in the forground.  Main loop should
         display the completion prompt. */
      MI_CMD_FORGROUND,
--- 27,36 ----
  enum mi_cmd_result
    {
      /* Report the command as ``done''.  Display both the ``NNN^done''
!        message and the completion prompt.  Start this at 1 so that
!        you can distinguish ALL these returns from the 0 of an error
!        in catch_errors. */
!     MI_CMD_DONE = 1,
      /* The command is still running in the forground.  Main loop should
         display the completion prompt. */
      MI_CMD_FORGROUND,


             reply	other threads:[~2002-05-17 21:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-17 14:29 Keith Seitz [this message]
2002-05-17 14:43 ` Andrew Cagney
2002-05-17 14:47   ` Keith Seitz
2002-05-20 10:08   ` Keith Seitz
2002-05-20 10:34     ` Andrew Cagney
2002-05-20 11:10       ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.33.0205171417280.2236-100000@makita.cygnus.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox